Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2796)

Unified Diff: chrome/android/java/res/layout/new_tab_page_progress_indicator.xml

Issue 2191593002: 📰 Add a spinner to indicate content is loading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix unit tests, add an extra one Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/res/values/dimens.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/layout/new_tab_page_progress_indicator.xml
diff --git a/chrome/android/java/res/layout/infobar_control_spinner.xml b/chrome/android/java/res/layout/new_tab_page_progress_indicator.xml
similarity index 56%
copy from chrome/android/java/res/layout/infobar_control_spinner.xml
copy to chrome/android/java/res/layout/new_tab_page_progress_indicator.xml
index f2006d6ae01f25981161a2156a3d6b515a46ac9f..0f15f834ebcd1b3397ebd65d915992c13962771e 100644
--- a/chrome/android/java/res/layout/infobar_control_spinner.xml
+++ b/chrome/android/java/res/layout/new_tab_page_progress_indicator.xml
@@ -3,8 +3,14 @@
Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file. -->
-<android.support.v7.widget.AppCompatSpinner
+<FrameLayout
xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
android:layout_height="wrap_content"
- android:minHeight="48dp" />
+ android:paddingTop="40dp">
+
+ <org.chromium.chrome.browser.ntp.cards.ProgressIndicatorView
+ android:id="@+id/snippets_progress"
+ android:layout_width="match_parent"
+ android:layout_height="@dimen/ntp_progress_indicator_diameter" />
+</FrameLayout>
« no previous file with comments | « no previous file | chrome/android/java/res/values/dimens.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698