Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1363)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2191543003: Remove existing FrameNavigationEntry when new named frame is added. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: New implementation of FNE clearing. More work needed. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 1fb9201c58d29fbde43c47ce8305b46c99893df0..d661bbc55d0911e1f91389586aede3af9e246844 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -81,6 +81,7 @@
#include "content/common/input/web_input_event_traits.h"
#include "content/common/input_messages.h"
#include "content/common/page_messages.h"
+#include "content/common/page_state_serialization.h"
#include "content/common/site_isolation_policy.h"
#include "content/common/ssl_status_serialization.h"
#include "content/common/view_messages.h"
@@ -4475,6 +4476,22 @@ void WebContentsImpl::UpdateStateForFrame(RenderFrameHost* render_frame_host,
if (page_state == frame_entry->page_state())
return; // Nothing to update.
+ // The document_sequence_number and item_sequence_number recorded in the
+ // FrameNavigationEntry should not differ from the one coming with the update,
+ // since it must come from the same document. Do not update it if a difference
+ // is detected, as this indicates that |frame_entry| is not the correct one.
+ ExplodedPageState exploded_state;
+ if (!DecodePageState(page_state.ToEncodedData(), &exploded_state))
+ return;
+
+ if (exploded_state.top.document_sequence_number !=
+ frame_entry->document_sequence_number() ||
+ exploded_state.top.item_sequence_number !=
+ frame_entry->item_sequence_number()) {
+ NOTREACHED();
+ return;
+ }
+
frame_entry->set_page_state(page_state);
controller_.NotifyEntryChanged(entry);
}

Powered by Google App Engine
This is Rietveld 408576698