content/browser/frame_host/navigation_entry_impl.h - Issue 2191543003: Remove existing FrameNavigationEntry when new named frame is added.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_entry_impl.h

Issue 2191543003: Remove existing FrameNavigationEntry when new named frame is added. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove extra pointer in test. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/navigation_controller_impl_browsertest.cc ('k') | content/browser/frame_host/navigation_entry_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_entry_impl.h

diff --git a/content/browser/frame_host/navigation_entry_impl.h b/content/browser/frame_host/navigation_entry_impl.h

index 83aed388371c8eab32b04c55dd33b3922bcf861e..e76f391ad6cceff250cf72f4c7f2e3ccc6d2675b 100644

--- a/content/browser/frame_host/navigation_entry_impl.h

+++ b/content/browser/frame_host/navigation_entry_impl.h

@@ -232,6 +232,12 @@ class CONTENT_EXPORT NavigationEntryImpl

// during session history navigations, when the child items no longer apply.

void ClearChildren(FrameTreeNode* frame_tree_node);

+ // Removes any subframe FrameNavigationEntries that match the unique name of

+ // |frame_tree_node|, and all of their children. There should be at most one,

+ // since collisions are avoided but leave old FrameNavigationEntries in the

+ // tree after their frame has been detached.

+ void ClearStaleFrameEntriesForNewFrame(FrameTreeNode* frame_tree_node);

void set_unique_id(int unique_id) {

unique_id_ = unique_id;

}