Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Side by Side Diff: content/browser/frame_host/navigation_entry_impl.h

Issue 2191543003: Remove existing FrameNavigationEntry when new named frame is added. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments addressed and refactored on top of TreeNode::parent. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 214 matching lines...) Expand 10 before | Expand all | Expand 10 after
225 225
226 // Returns the FrameNavigationEntry corresponding to |frame_tree_node|, if 226 // Returns the FrameNavigationEntry corresponding to |frame_tree_node|, if
227 // there is one in this NavigationEntry. 227 // there is one in this NavigationEntry.
228 FrameNavigationEntry* GetFrameEntry(FrameTreeNode* frame_tree_node) const; 228 FrameNavigationEntry* GetFrameEntry(FrameTreeNode* frame_tree_node) const;
229 229
230 // Removes subframe FrameNavigationEntries below the item corresponding to 230 // Removes subframe FrameNavigationEntries below the item corresponding to
231 // |frame_tree_node| (if any). This is necessary after server redirects 231 // |frame_tree_node| (if any). This is necessary after server redirects
232 // during session history navigations, when the child items no longer apply. 232 // during session history navigations, when the child items no longer apply.
233 void ClearChildren(FrameTreeNode* frame_tree_node); 233 void ClearChildren(FrameTreeNode* frame_tree_node);
234 234
235 // Removes any subframe FrameNavigationEntries that match the unique name of
236 // |frame_tree_node|, and all of their children. There should be at most one,
237 // since collisions are avoided but leave old FrameNavigationEntries in the
238 // tree after their frame has been detached.
239 void ClearStaleFrameEntriesForNewFrame(FrameTreeNode* frame_tree_node);
240
235 void set_unique_id(int unique_id) { 241 void set_unique_id(int unique_id) {
236 unique_id_ = unique_id; 242 unique_id_ = unique_id;
237 } 243 }
238 244
239 // The SiteInstance represents which pages must share processes. This is a 245 // The SiteInstance represents which pages must share processes. This is a
240 // reference counted pointer to a shared SiteInstance. 246 // reference counted pointer to a shared SiteInstance.
241 // 247 //
242 // Note that the SiteInstance should usually not be changed after it is set, 248 // Note that the SiteInstance should usually not be changed after it is set,
243 // but this may happen if the NavigationEntry was cloned and needs to use a 249 // but this may happen if the NavigationEntry was cloned and needs to use a
244 // different SiteInstance. 250 // different SiteInstance.
(...skipping 276 matching lines...) Expand 10 before | Expand all | Expand 10 after
521 // persisted, unless specific data is taken out/put back in at save/restore 527 // persisted, unless specific data is taken out/put back in at save/restore
522 // time (see TabNavigation for an example of this). 528 // time (see TabNavigation for an example of this).
523 std::map<std::string, base::string16> extra_data_; 529 std::map<std::string, base::string16> extra_data_;
524 530
525 DISALLOW_COPY_AND_ASSIGN(NavigationEntryImpl); 531 DISALLOW_COPY_AND_ASSIGN(NavigationEntryImpl);
526 }; 532 };
527 533
528 } // namespace content 534 } // namespace content
529 535
530 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_ 536 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698