Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1757)

Unified Diff: third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp

Issue 2191533003: Refactor Timer classes in preparation for landing FrameTimers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More build fixes Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp
diff --git a/third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp b/third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp
index 4ad63e8ced4f1a95090125af45e61f364d933add..a738ac540f2c200bf87635d6c62a26b11132a483 100644
--- a/third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp
+++ b/third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp
@@ -9,6 +9,7 @@
#include "platform/graphics/GraphicsContext.h"
#include "platform/graphics/paint/PaintController.h"
#include "testing/gtest/include/gtest/gtest.h"
+#include "wtf/PtrUtil.h"
#include <memory>
namespace blink {
@@ -141,17 +142,18 @@ private:
Task* m_currentTask;
};
-class MockTimer : public Timer<ImageQualityController> {
- typedef void (ImageQualityController::*TimerFiredFunction)(Timer*);
+class MockTimer : public TaskRunnerTimer<ImageQualityController> {
public:
+ using TimerFiredFunction = typename TaskRunnerTimer<ImageQualityController>::TimerFiredFunction;
+
MockTimer(ImageQualityController* o, TimerFiredFunction f)
- : Timer<ImageQualityController>(o, f, &m_taskRunner)
+ : TaskRunnerTimer(&m_taskRunner, o, f)
{
}
void fire()
{
- this->Timer<ImageQualityController>::fired();
+ fired();
stop();
}
@@ -167,7 +169,7 @@ private:
TEST_F(ImageQualityControllerTest, LowQualityFilterForResizingImage)
{
MockTimer* mockTimer = new MockTimer(controller(), &ImageQualityController::highQualityRepaintTimerFired);
- controller()->setTimer(mockTimer);
+ controller()->setTimer(wrapUnique(mockTimer));
setBodyInnerHTML("<img src='myimage'></img>");
LayoutImage* img = toLayoutImage(document().body()->firstChild()->layoutObject());
@@ -192,7 +194,7 @@ TEST_F(ImageQualityControllerTest, LowQualityFilterForResizingImage)
TEST_F(ImageQualityControllerTest, MediumQualityFilterForNotAnimatedWhileAnotherAnimates)
{
MockTimer* mockTimer = new MockTimer(controller(), &ImageQualityController::highQualityRepaintTimerFired);
- controller()->setTimer(mockTimer);
+ controller()->setTimer(wrapUnique(mockTimer));
setBodyInnerHTML("<img id='myAnimatingImage' src='myimage'></img> <img id='myNonAnimatingImage' src='myimage2'></img>");
LayoutImage* animatingImage = toLayoutImage(document().getElementById("myAnimatingImage")->layoutObject());
LayoutImage* nonAnimatingImage = toLayoutImage(document().getElementById("myNonAnimatingImage")->layoutObject());
@@ -222,7 +224,7 @@ TEST_F(ImageQualityControllerTest, MediumQualityFilterForNotAnimatedWhileAnother
TEST_F(ImageQualityControllerTest, DontKickTheAnimationTimerWhenPaintingAtTheSameSize)
{
MockTimer* mockTimer = new MockTimer(controller(), &ImageQualityController::highQualityRepaintTimerFired);
- controller()->setTimer(mockTimer);
+ controller()->setTimer(wrapUnique(mockTimer));
setBodyInnerHTML("<img src='myimage'></img>");
LayoutImage* img = toLayoutImage(document().body()->firstChild()->layoutObject());
@@ -248,7 +250,7 @@ TEST_F(ImageQualityControllerTest, DontKickTheAnimationTimerWhenPaintingAtTheSam
TEST_F(ImageQualityControllerTest, DontRestartTimerUnlessAdvanced)
{
MockTimer* mockTimer = new MockTimer(controller(), &ImageQualityController::highQualityRepaintTimerFired);
- controller()->setTimer(mockTimer);
+ controller()->setTimer(wrapUnique(mockTimer));
setBodyInnerHTML("<img src='myimage'></img>");
LayoutImage* img = toLayoutImage(document().body()->firstChild()->layoutObject());

Powered by Google App Engine
This is Rietveld 408576698