third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp - Issue 2191533003: Refactor Timer classes in preparation for landing FrameTimers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp

Issue 2191533003: Refactor Timer classes in preparation for landing FrameTimers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More build fixes Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h ('k') | third_party/WebKit/Source/bindings/core/v8/V8GCForContextDispose.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp

index 04dc617a78249cf667bcba3c03a41b142661f562..f8a8480eb975bcab9502d44ae6bff2c47da94d4f 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp

@@ -61,7 +61,7 @@ void ScriptPromiseResolver::keepAliveWhilePending()

m_keepAlive = this;

}

-void ScriptPromiseResolver::onTimerFired(Timer<ScriptPromiseResolver>*)

+void ScriptPromiseResolver::onTimerFired(TimerBase*)

{

ASSERT(m_state == Resolving || m_state == Rejecting);

if (!getScriptState()->contextIsValid()) {