third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp - Issue 2191533003: Refactor Timer classes in preparation for landing FrameTimers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

Issue 2191533003: Refactor Timer classes in preparation for landing FrameTimers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Android build fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/input/EventHandler.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h » ('j') | third_party/WebKit/Source/core/loader/FrameLoader.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

index 22e36492c4b31ee7cbc5e6c5591d318c61bab528..a81d2cc29b075c0576a2fb02765e824443c67e5d 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

@@ -143,7 +143,7 @@ public:

explicit InspectorRevalidateDOMTask(InspectorDOMAgent*);

void scheduleStyleAttrRevalidationFor(Element*);

void reset() { m_timer.stop(); }

- void onTimer(Timer<InspectorRevalidateDOMTask>*);

+ void onTimer(TimerBase*);

DECLARE_TRACE();

private:

@@ -165,7 +165,7 @@ void InspectorRevalidateDOMTask::scheduleStyleAttrRevalidationFor(Element* eleme

m_timer.startOneShot(0, BLINK_FROM_HERE);

}

-void InspectorRevalidateDOMTask::onTimer(Timer<InspectorRevalidateDOMTask>*)

+void InspectorRevalidateDOMTask::onTimer(TimerBase*)

{

// The timer is stopped on m_domAgent destruction, so this method will never be called after m_domAgent has been destroyed.

HeapVector<Member<Element>> elements;