third_party/WebKit/Source/web/WebHelperPluginImpl.h - Issue 2191533003: Refactor Timer classes in preparation for landing FrameTimers.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/web/WebHelperPluginImpl.h

Issue 2191533003: Refactor Timer classes in preparation for landing FrameTimers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More build fixes Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Google Inc. All rights reserved.	2 * Copyright (C) 2012 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 44 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
55 WebPlugin* getPlugin() override;	55 WebPlugin* getPlugin() override;

56 void destroy() override;	56 void destroy() override;

57	57

58 private:	58 private:

59 friend class WebHelperPlugin;	59 friend class WebHelperPlugin;

60	60

61 WebHelperPluginImpl();	61 WebHelperPluginImpl();

62 ~WebHelperPluginImpl() override;	62 ~WebHelperPluginImpl() override;

63	63

64 bool initialize(const String& pluginType, WebLocalFrameImpl*);	64 bool initialize(const String& pluginType, WebLocalFrameImpl*);

65 void reallyDestroy(Timer<WebHelperPluginImpl>*);	65 void reallyDestroy(TimerBase*);

66	66

67 Timer<WebHelperPluginImpl> m_destructionTimer;	67 Timer<WebHelperPluginImpl> m_destructionTimer;

68 Persistent<HTMLObjectElement> m_objectElement;	68 Persistent<HTMLObjectElement> m_objectElement;

69 Persistent<WebPluginContainerImpl> m_pluginContainer;	69 Persistent<WebPluginContainerImpl> m_pluginContainer;

70 };	70 };

71	71

72 } // namespace blink	72 } // namespace blink

73	73

74 #endif // WebHelperPluginImpl_h	74 #endif // WebHelperPluginImpl_h

OLD	NEW