Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 2191533002: [turbofan] Remove access to FunctionType from call interface. (Closed)

Created:
4 years, 4 months ago by Michael Starzinger
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove access to FunctionType from call interface. This removes the ability to directly access the {FunctionType} stored within a {CallInterfaceDescriptor}. The field is in the process of being deprecated and should no longer be accessed. R=bmeurer@chromium.org Committed: https://crrev.com/f402d66cd2b01cdd8222aa212f834611bf6d4be6 Cr-Commit-Position: refs/heads/master@{#38107}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M src/builtins/builtins.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/interface-descriptors.h View 3 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Starzinger
4 years, 4 months ago (2016-07-27 14:12:33 UTC) #3
Benedikt Meurer
lgtm
4 years, 4 months ago (2016-07-27 17:25:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191533002/1
4 years, 4 months ago (2016-07-27 17:25:47 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 17:27:38 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 17:30:02 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f402d66cd2b01cdd8222aa212f834611bf6d4be6
Cr-Commit-Position: refs/heads/master@{#38107}

Powered by Google App Engine
This is Rietveld 408576698