Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2191503002: [turbofan] Add the CheckedTruncateTaggedToWord32 opcode. (Closed)

Created:
4 years, 4 months ago by epertoso
Modified:
4 years, 4 months ago
Reviewers:
*Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add the CheckedTruncateTaggedToWord32 opcode. This leads to a better handling of the Smi case when we introduce a checked truncation from a number or oddbal to a 32 bit word, which we were previously doing by concatenating a Smi to float64 conversion with a float64 to word32 truncation. BUG= Committed: https://crrev.com/43a86ff3b74c0fbc84bbe56a132f31db4b035240 Cr-Commit-Position: refs/heads/master@{#38091}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -27 lines) Patch
M src/compiler/effect-control-linearizer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 2 chunks +39 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/representation-change.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +18 lines, -17 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-representation-change.cc View 3 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
epertoso
4 years, 4 months ago (2016-07-27 11:04:42 UTC) #4
Benedikt Meurer
Nice. LGTM.
4 years, 4 months ago (2016-07-27 11:07:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191503002/1
4 years, 4 months ago (2016-07-27 11:15:11 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 11:38:20 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 11:41:38 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43a86ff3b74c0fbc84bbe56a132f31db4b035240
Cr-Commit-Position: refs/heads/master@{#38091}

Powered by Google App Engine
This is Rietveld 408576698