Form submission should abort before constraint validation if sandboxed forms flag is set.

Form submission should abort before constraint validation if sandboxed forms flag is set.

BUG=630628
Committed: https://crrev.com/fb9cf630dda67c9e09ac6d9b8e14696c12784387
Cr-Commit-Position: refs/heads/master@{#408950}

[Mike West, 2016-07-28 09:26:47]

mkwst@chromium.org changed reviewers:
+ mkwst@chromium.org

[Mike West, 2016-07-28 09:26:48]

https://codereview.chromium.org/2191493002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLFormElement.cpp (right):

https://codereview.chromium.org/2191493002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLFormElement.cpp:300: // FIXME: This
message should be moved off the console once a solution to
https://bugs.webkit.org/show_bug.cgi?id=103274 exists.
Drop this comment; at this point, I don't think we're going to move these
anywhere. Maybe someone will incorporate them into the security panel at some
point, but no one's actively working on a design for that, and the linked bug is
4 years old.

https://codereview.chromium.org/2191493002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLFormElement.cpp:403: if
(document().isSandboxed(SandboxForms)) {
Can we change this to a DCHECK? I think `prepareForSubmission` is always called
before `submit()` (which calls this method).

[ramya.v, 2016-07-28 09:37:15]

@Mike West Thanks for the review! :)
Updated comments.
PTAL!

Thanks

https://codereview.chromium.org/2191493002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLFormElement.cpp (right):

https://codereview.chromium.org/2191493002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLFormElement.cpp:300: // FIXME: This
message should be moved off the console once a solution to
https://bugs.webkit.org/show_bug.cgi?id=103274 exists.
On 2016/07/28 09:26:47, Mike West wrote:
> Drop this comment; at this point, I don't think we're going to move these
> anywhere. Maybe someone will incorporate them into the security panel at some
> point, but no one's actively working on a design for that, and the linked bug
is
> 4 years old.

Done.

https://codereview.chromium.org/2191493002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLFormElement.cpp:403: if
(document().isSandboxed(SandboxForms)) {
On 2016/07/28 09:26:47, Mike West wrote:
> Can we change this to a DCHECK? I think `prepareForSubmission` is always
called
> before `submit()` (which calls this method).


I tried removing this code from here in patchset1. Its giving below failures.
https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r...

[Mike West, 2016-08-01 11:46:59]

Hrm. Ok. LGTM.

[ramya.v, 2016-08-01 11:47:29]

The CQ bit was checked by ramya.v@samsung.com

[commit-bot: I haz the power, 2016-08-01 11:47:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 13:10:32]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-01 13:12:02]

Description was changed from

==========
Form submission should abort before constraint validation if sandboxed forms
flag is set.

BUG=630628
==========

to

==========
Form submission should abort before constraint validation if sandboxed forms
flag is set.

BUG=630628

Committed: https://crrev.com/fb9cf630dda67c9e09ac6d9b8e14696c12784387
Cr-Commit-Position: refs/heads/master@{#408950}
==========

[commit-bot: I haz the power, 2016-08-01 13:12:06]

Patchset 4 (id:??) landed as
https://crrev.com/fb9cf630dda67c9e09ac6d9b8e14696c12784387
Cr-Commit-Position: refs/heads/master@{#408950}