Remove dead code from compile.py.

Remove dead code from compile.py.

Removed following code:
- code to set NO_NACL_GOMA in certain hosts.
  Since GN become default build system for Windows, no need to set
  option only used by gyp.
- manually disables burst mode on network failure.
  Now we gathers compiler_proxy.INFO via cloudtail, we do not need
  to disable the feature to check it does something bad or not.
- setting goma.key
  We have already deprecated goma.key, no need to have that like this.
- setting '?win' for Windows.
  goma_ctl.py does this job, we do not need to have the code here.
- options.compiler in ('goma', 'goma-clang') in goma_teardown.
  The same check has been done in goma_setup, and it sets
  options.goma_dir = None if goma is not used, no need to have
  duplicated check.
- args option in get_target_build_dir
  get_target_build_dir does not use args.

Minor fixes:
- mentioned about env modification in goma_setup function comment.
- like other options do, overwrite env if options.goma_hermetic is set.
- Fixed the explanation on why goma_ctl.py stop should be done.

BUG=631920
Committed: https://chromium.googlesource.com/chromium/tools/build/+/c5770707665087d737ef6e738622a1bd7bc6609b

[Yoshisato Yanagisawa, 2016-07-27 08:25:18]

yyanagisawa@chromium.org changed reviewers:
+ shinyak@chromium.org, tikuta@chromium.org, ukai@chromium.org

[shinyak, 2016-07-27 08:40:52]

lgtm

[tikuta, 2016-07-27 08:44:09]

lgtm

[Yoshisato Yanagisawa, 2016-07-29 00:52:05]

The CQ bit was checked by yyanagisawa@chromium.org

[commit-bot: I haz the power, 2016-07-29 00:52:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 00:56:49]

Description was changed from

==========
Remove dead code from compile.py.

Removed following code:
- code to set NO_NACL_GOMA in certain hosts.
  Since GN become default build system for Windows, no need to set
  option only used by gyp.
- manually disables burst mode on network failure.
  Now we gathers compiler_proxy.INFO via cloudtail, we do not need
  to disable the feature to check it does something bad or not.
- setting goma.key
  We have already deprecated goma.key, no need to have that like this.
- setting '?win' for Windows.
  goma_ctl.py does this job, we do not need to have the code here.
- options.compiler in ('goma', 'goma-clang') in goma_teardown.
  The same check has been done in goma_setup, and it sets
  options.goma_dir = None if goma is not used, no need to have
  duplicated check.
- args option in get_target_build_dir
  get_target_build_dir does not use args.

Minor fixes:
- mentioned about env modification in goma_setup function comment.
- like other options do, overwrite env if options.goma_hermetic is set.
- Fixed the explanation on why goma_ctl.py stop should be done.

BUG=631920
==========

to

==========
Remove dead code from compile.py.

Removed following code:
- code to set NO_NACL_GOMA in certain hosts.
  Since GN become default build system for Windows, no need to set
  option only used by gyp.
- manually disables burst mode on network failure.
  Now we gathers compiler_proxy.INFO via cloudtail, we do not need
  to disable the feature to check it does something bad or not.
- setting goma.key
  We have already deprecated goma.key, no need to have that like this.
- setting '?win' for Windows.
  goma_ctl.py does this job, we do not need to have the code here.
- options.compiler in ('goma', 'goma-clang') in goma_teardown.
  The same check has been done in goma_setup, and it sets
  options.goma_dir = None if goma is not used, no need to have
  duplicated check.
- args option in get_target_build_dir
  get_target_build_dir does not use args.

Minor fixes:
- mentioned about env modification in goma_setup function comment.
- like other options do, overwrite env if options.goma_hermetic is set.
- Fixed the explanation on why goma_ctl.py stop should be done.

BUG=631920

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/c5770707665087d737ef...
==========

[commit-bot: I haz the power, 2016-07-29 00:56:50]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/c5770707665087d737ef...

[Nico, 2016-07-29 17:33:20]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-07-29 17:33:20]

Thank you for the cleanup!

Note that branch builders also use this script (and the latest version of it),
and the stable branch doesn't use gn yet. I'm not sure if the branch builders
use goma though. If they don't, this change should be ok.

[Yoshisato Yanagisawa, 2016-08-01 02:13:42]

On 2016/07/29 17:33:20, Nico (ooo until Aug 1) wrote:
> Thank you for the cleanup!
> 
> Note that branch builders also use this script (and the latest version of it),
> and the stable branch doesn't use gn yet. I'm not sure if the branch builders
> use goma though. If they don't, this change should be ok.

If you are talking about NO_NACL_GOMA, all hostnames are chromium.fyi bots.