Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issue 2191473006: Re-land "Flip the last Mac GYP bots to GN (the ASAN bots)" (Closed)

Created:
4 years, 4 months ago by Dirk Pranke
Modified:
4 years, 4 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land "Flip the last Mac GYP bots to GN (the ASAN bots)" This re-lands r408345 with the needed fix to the Mac ASAN 64 Builder on chromium.memory (by turning off lsan). TBR=rsesek@chromium.org BUG=618468, 630322, 632059 Committed: https://crrev.com/8c07d4e0af781b15ad65c50f8a9127d4ab5db01f Cr-Commit-Position: refs/heads/master@{#408422}

Patch Set 1 : original CL #

Patch Set 2 : turn off lsan on mac builder #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -20 lines) Patch
M chrome/chrome_tests.gypi View 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M tools/mb/mb_config.pyl View 1 8 chunks +30 lines, -19 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Dirk Pranke
4 years, 4 months ago (2016-07-28 14:44:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191473006/20001
4 years, 4 months ago (2016-07-28 14:44:39 UTC) #3
Robert Sesek
LGTM
4 years, 4 months ago (2016-07-28 14:44:55 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/112327)
4 years, 4 months ago (2016-07-28 15:28:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191473006/20001
4 years, 4 months ago (2016-07-28 16:30:42 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-28 17:32:57 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 17:35:00 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8c07d4e0af781b15ad65c50f8a9127d4ab5db01f
Cr-Commit-Position: refs/heads/master@{#408422}

Powered by Google App Engine
This is Rietveld 408576698