Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 2191473005: DevTools: remove release mode from runtime. (Closed)

Created:
4 years, 4 months ago by pfeldman
Modified:
4 years, 4 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: remove release mode from runtime. Committed: https://crrev.com/c7499c30537bdd50baeb177aeff3e85e13f3ea0f Cr-Commit-Position: refs/heads/master@{#408287}

Patch Set 1 #

Total comments: 1

Patch Set 2 : lcean #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -148 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/runtime.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 2 chunks +48 lines, -48 lines 0 comments Download
M third_party/WebKit/Source/devtools/devtools.gyp View 2 chunks +48 lines, -48 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Runtime.js View 1 9 chunks +16 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/inspector.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/concatenate_application_code.py View 1 3 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
pfeldman
4 years, 4 months ago (2016-07-27 21:55:14 UTC) #2
dgozman
lgtm https://codereview.chromium.org/2191473005/diff/1/third_party/WebKit/Source/devtools/front_end/Runtime.js File third_party/WebKit/Source/devtools/front_end/Runtime.js (right): https://codereview.chromium.org/2191473005/diff/1/third_party/WebKit/Source/devtools/front_end/Runtime.js#newcode811 third_party/WebKit/Source/devtools/front_end/Runtime.js:811: return loadScriptsPromise(this._descriptor.scripts.map(this._modularizeURL, this), this._remoteBase()); This makes it hard ...
4 years, 4 months ago (2016-07-27 22:10:46 UTC) #3
pfeldman
On 2016/07/27 22:10:46, dgozman wrote: > lgtm > > https://codereview.chromium.org/2191473005/diff/1/third_party/WebKit/Source/devtools/front_end/Runtime.js > File third_party/WebKit/Source/devtools/front_end/Runtime.js (right): > ...
4 years, 4 months ago (2016-07-27 22:12:33 UTC) #4
pfeldman
On 2016/07/27 22:12:33, pfeldman wrote: > On 2016/07/27 22:10:46, dgozman wrote: > > lgtm > ...
4 years, 4 months ago (2016-07-27 22:13:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191473005/20001
4 years, 4 months ago (2016-07-27 22:53:46 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-28 00:09:24 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 00:14:08 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c7499c30537bdd50baeb177aeff3e85e13f3ea0f
Cr-Commit-Position: refs/heads/master@{#408287}

Powered by Google App Engine
This is Rietveld 408576698