third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp - Issue 2191443002: Ensure the permissions DOMTokenList is initialized before access

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp

Issue 2191443002: Ensure the permissions DOMTokenList is initialized before access (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/HTMLIFrameElement.h ('K') | « third_party/WebKit/Source/core/html/HTMLIFrameElement.h ('k') | third_party/WebKit/Source/core/html/HTMLIFrameElementTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp b/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp

index a68f5d7774d4e23cd38ff2668fc0550fc47c248b..249f11600f42e8f949ae581b3b60c8c3d0fa1e5b 100644

--- a/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp

@@ -61,8 +61,10 @@ DOMTokenList* HTMLIFrameElement::sandbox() const

return m_sandbox.get();

}

-DOMTokenList* HTMLIFrameElement::permissions() const

+DOMTokenList* HTMLIFrameElement::permissions()

{

+ if (!initializePermissionsAttribute())

esprehn 2016/07/27 06:05:56 How can this fail? Does the spec say it can be nul

raymes 2016/07/27 06:13:45 Sorry my description was inaccurate. It doesn't ac

+ return nullptr;

return m_permissions.get();

}