Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 219143004: Improve wallpaper policy tests. (Closed)

Created:
6 years, 8 months ago by Thiemo Nagel
Modified:
6 years, 8 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+ash_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@wallpaper-2nd-test
Visibility:
Public.

Description

Improve wallpaper policy tests. Check switching between pods on login screen and add new test to check wallpaper persistence across logout. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266154

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Rebased. #

Total comments: 2

Patch Set 3 : Rebase. #

Patch Set 4 : Fix comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -2 lines) Patch
M chrome/browser/chromeos/login/wallpaper_manager_policy_browsertest.cc View 1 2 3 4 chunks +57 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Thiemo Nagel
Hi Nikita, may I kindly ask you to take a look at this CL, which ...
6 years, 8 months ago (2014-03-31 21:31:51 UTC) #1
Nikita (slow)
https://codereview.chromium.org/219143004/diff/20001/chrome/browser/chromeos/login/wallpaper_manager_policy_browsertest.cc File chrome/browser/chromeos/login/wallpaper_manager_policy_browsertest.cc (right): https://codereview.chromium.org/219143004/diff/20001/chrome/browser/chromeos/login/wallpaper_manager_policy_browsertest.cc#newcode190 chrome/browser/chromeos/login/wallpaper_manager_policy_browsertest.cc:190: if (std::string(test_info->name()) == "PRE_WallpaperOnLoginScreen/0") { Is there a way ...
6 years, 8 months ago (2014-04-15 13:41:27 UTC) #2
Thiemo Nagel
https://codereview.chromium.org/219143004/diff/20001/chrome/browser/chromeos/login/wallpaper_manager_policy_browsertest.cc File chrome/browser/chromeos/login/wallpaper_manager_policy_browsertest.cc (right): https://codereview.chromium.org/219143004/diff/20001/chrome/browser/chromeos/login/wallpaper_manager_policy_browsertest.cc#newcode190 chrome/browser/chromeos/login/wallpaper_manager_policy_browsertest.cc:190: if (std::string(test_info->name()) == "PRE_WallpaperOnLoginScreen/0") { On 2014/04/15 13:41:27, Nikita ...
6 years, 8 months ago (2014-04-15 13:50:30 UTC) #3
Thiemo Nagel
I've rebased now and removed the hack. Could you please take another look? Thank you! ...
6 years, 8 months ago (2014-04-16 14:29:37 UTC) #4
Nikita (slow)
lgtm https://codereview.chromium.org/219143004/diff/40001/chrome/browser/chromeos/login/wallpaper_manager_policy_browsertest.cc File chrome/browser/chromeos/login/wallpaper_manager_policy_browsertest.cc (right): https://codereview.chromium.org/219143004/diff/40001/chrome/browser/chromeos/login/wallpaper_manager_policy_browsertest.cc#newcode359 chrome/browser/chromeos/login/wallpaper_manager_policy_browsertest.cc:359: // Set wallpaper policy to red image. nit: ...
6 years, 8 months ago (2014-04-18 08:58:51 UTC) #5
Thiemo Nagel
https://codereview.chromium.org/219143004/diff/40001/chrome/browser/chromeos/login/wallpaper_manager_policy_browsertest.cc File chrome/browser/chromeos/login/wallpaper_manager_policy_browsertest.cc (right): https://codereview.chromium.org/219143004/diff/40001/chrome/browser/chromeos/login/wallpaper_manager_policy_browsertest.cc#newcode359 chrome/browser/chromeos/login/wallpaper_manager_policy_browsertest.cc:359: // Set wallpaper policy to red image. On 2014/04/18 ...
6 years, 8 months ago (2014-04-24 11:27:28 UTC) #6
Thiemo Nagel
The CQ bit was checked by tnagel@chromium.org
6 years, 8 months ago (2014-04-24 16:35:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/219143004/80001
6 years, 8 months ago (2014-04-24 16:39:03 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 21:07:20 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-24 21:07:21 UTC) #10
Thiemo Nagel
The CQ bit was checked by tnagel@chromium.org
6 years, 8 months ago (2014-04-25 05:45:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/219143004/80001
6 years, 8 months ago (2014-04-25 07:49:55 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 08:27:58 UTC) #13
Message was sent while issue was closed. 
Change committed as 266154

Powered by Google App Engine
This is Rietveld 408576698