Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2191413003: DevTools: [SSP] do not throw exception if click on yellow triangle (Closed)

Created:
4 years, 4 months ago by lushnikov
Modified:
4 years, 4 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [SSP] do not throw exception if click on yellow triangle The patch avoids throwing exception in the following scenario: - add any non-existing property in SSP, e.g. "foo: bar;" - observe a yellow triangle next to the property - try clicking this triangle BUG=none R=dgozman Committed: https://crrev.com/66d4177ededb848e08ab24d5375245581c634daf Cr-Commit-Position: refs/heads/master@{#408875}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
lushnikov
please, take a look
4 years, 4 months ago (2016-07-30 04:24:49 UTC) #1
dgozman
Is it easy to add a test? lgtm
4 years, 4 months ago (2016-07-30 16:00:42 UTC) #6
lushnikov
it's not hard to add a test, but given this is a minor UX issue, ...
4 years, 4 months ago (2016-07-30 18:59:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191413003/1
4 years, 4 months ago (2016-07-30 20:18:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-30 20:22:46 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-30 20:25:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66d4177ededb848e08ab24d5375245581c634daf
Cr-Commit-Position: refs/heads/master@{#408875}

Powered by Google App Engine
This is Rietveld 408576698