Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2191403002:
Update histgrams.xml for ArcProvisioningResult. (Closed)
|
Created:
4 years, 4 months ago by hidehiko Modified:
4 years, 4 months ago CC:
chromium-reviews, asvitkine+watch_chromium.org, Junichi Uekawa, elijahtaylor1 Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate histgrams.xml for ArcProvisioningResult.
The ArcProvisioningResult was extended
https://codereview.chromium.org/2173103002/diff/140001/chrome/browser/chromeos/arc/arc_optin_uma.h
but histgrams.xml was not updated in the CL.
This CL updates to adapt the new values.
BUG=630624
TEST=Ran trybots.
Committed: https://crrev.com/61a81ea6bcccee7cd6392f9f286ae0df99cd1054
Cr-Commit-Position: refs/heads/master@{#409146}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Address comment. #Messages
Total messages: 21 (11 generated)
The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
hidehiko@chromium.org changed reviewers: + isherman@chromium.org, khmel@chromium.org
Could you take a look? Thank you for review in advance, - hidehiko
On 2016/07/29 19:31:53, hidehiko wrote: > Could you take a look? > > Thank you for review in advance, > - hidehiko Could you please update section (ArcOptInCancel) above also? You marked some enums as DEPRICATED_
https://codereview.chromium.org/2191403002/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2191403002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:66768: - <int value="5" label="GMS Core is not available"/> It looks like you are changing the semantics of this bucket. Is that true, or are you simply clarifying what the semantics were all along?
Thank you for review. PTAL. > Could you please update section (ArcOptInCancel) above also? You marked some enums as DEPRICATED_ Done, added deprecated text to labels. https://codereview.chromium.org/2191403002/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2191403002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:66768: - <int value="5" label="GMS Core is not available"/> On 2016/07/29 21:16:42, Ilya Sherman wrote: > It looks like you are changing the semantics of this bucket. Is that true, or > are you simply clarifying what the semantics were all along? Latter. I changed some existing labels just because they were not clear on semantics or sometimes misleading, so to adapt the current usage. New ones are added to set precise status code for more situations.
The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Okay, lgtm -- thanks.
Thank you for review, Ilya. Friendly ping, Yury?
Thanks for updating! lgtm
The CQ bit was checked by hidehiko@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Update histgrams.xml for ArcProvisioningResult. The ArcProvisioningResult was extended https://codereview.chromium.org/2173103002/diff/140001/chrome/browser/chromeo... but histgrams.xml was not updated in the CL. This CL updates to adapt the new values. BUG=630624 TEST=Ran trybots. ========== to ========== Update histgrams.xml for ArcProvisioningResult. The ArcProvisioningResult was extended https://codereview.chromium.org/2173103002/diff/140001/chrome/browser/chromeo... but histgrams.xml was not updated in the CL. This CL updates to adapt the new values. BUG=630624 TEST=Ran trybots. Committed: https://crrev.com/61a81ea6bcccee7cd6392f9f286ae0df99cd1054 Cr-Commit-Position: refs/heads/master@{#409146} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/61a81ea6bcccee7cd6392f9f286ae0df99cd1054 Cr-Commit-Position: refs/heads/master@{#409146} |
