Reland of "Apply Shelf/Dock opacity animations for the Material Design style."

Reland of "Apply Shelf/Dock opacity animations for the Material Design style."

The Shelf animates between the 3 ShelfBackgroundType's using 2
different animations; one uses BackgroundAnimator timers and
View::OnPaint() and the other uses a Layer to animate the
SHELF_BACKGROUND_MAXIMIZED opaque background.

This change centralizes the animation logic so they all stay in sync
and applies the opacity animations to the material design style
Shelf/Dock.

Eventually the ShelfBackgroundAnimator will be enhanced to animate
between colors instead of just alpha values.

Follow-up plans:
 - Use a single instance of the ShelfBackgroundAnimator.
 - Remove the |opaque_background_| from ShelfWidget and
   DockedBackgroundWidget.
 - Collapse the multiple BackgroundAnimators owned by the
   ShelfBackgroundAnimator into a single SlideAnimation.
 - Animate the MD AppList and Overflow buttons.

BUG=607037
Committed: https://crrev.com/a2239af6304ceaac998a487cf3cd09e9c23ebfc5
Cr-Commit-Position: refs/heads/master@{#409211}

[bruthig, 2016-07-29 14:35:56]

Description was changed from

==========
Reland of "Replaced BackgroundAnimator with ShelfBackgroundAnimator."


BUG=
==========

to

==========
Reland of "Apply Shelf/Dock opacity animations for the Material Design style."

The Shelf animates between the 3 ShelfBackgroundType's using 2
different animations; one uses BackgroundAnimator timers and
View::OnPaint() and the other uses a Layer to animate the
SHELF_BACKGROUND_MAXIMIZED opaque background.

This change centralizes the animation logic so they all stay in sync
and applies the opacity animations to the material design style
Shelf/Dock.

Eventually the ShelfBackgroundAnimator will be enhanced to animate
between colors instead of just alpha values.

Follow-up plans:
 - Use a single instance of the ShelfBackgroundAnimator.
 - Remove the |opaque_background_| from ShelfWidget and
   DockedBackgroundWidget.
 - Collapse the multiple BackgroundAnimators owned by the
   ShelfBackgroundAnimator into a single SlideAnimation.
 - Animate the MD AppList and Overflow buttons.

BUG=607037
==========

[bruthig, 2016-07-29 17:12:55]

bruthig@chromium.org changed reviewers:
+ jamescook@chromium.org

[bruthig, 2016-07-29 17:12:56]

James, I had to fix up some memory errors.  Patch set 1 is the patch set that
landed and patch set 2 is the new changes to fix the memory errors.

The problem is the ShelfWidget dtor finishes before the ShelfView's dtor and
destroys the BackgroundAnimator instance before the ShelfView can remove itself
as an observer.

Can you please take a look?

[bruthig, 2016-07-29 17:13:08]

The CQ bit was checked by bruthig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 17:13:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 17:46:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 17:46:17]

Dry run: This issue passed the CQ dry run.

[James Cook, 2016-08-01 16:37:03]

https://codereview.chromium.org/2191363002/diff/20001/ash/shelf/shelf_widget.cc
File ash/shelf/shelf_widget.cc (right):

https://codereview.chromium.org/2191363002/diff/20001/ash/shelf/shelf_widget....
ash/shelf/shelf_widget.cc:637: background_animator_.RemoveObserver(this);
At the login screen, if a secondary monitor is disconnected, the ShelfWidget can
be destroyed without CreateShelf being called. While this won't crash, I think
you should either check HasObserver first, or add the observer in the
constructor and use a different method to notify the shelf of initial values.

--login-manager --ash-debug-shortcuts Ctrl-Shift-D a couple times will test this
behavior manually

[bruthig, 2016-08-02 15:48:30]

James, can you take another look?

https://codereview.chromium.org/2191363002/diff/20001/ash/shelf/shelf_widget.cc
File ash/shelf/shelf_widget.cc (right):

https://codereview.chromium.org/2191363002/diff/20001/ash/shelf/shelf_widget....
ash/shelf/shelf_widget.cc:637: background_animator_.RemoveObserver(this);
On 2016/08/01 16:37:03, James Cook wrote:
> At the login screen, if a secondary monitor is disconnected, the ShelfWidget
can
> be destroyed without CreateShelf being called. While this won't crash, I think
> you should either check HasObserver first, or add the observer in the
> constructor and use a different method to notify the shelf of initial values.
> 
> --login-manager --ash-debug-shortcuts Ctrl-Shift-D a couple times will test
this
> behavior manually

Done.

[bruthig, 2016-08-02 16:12:14]

The CQ bit was checked by bruthig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 16:12:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-08-02 16:54:44]

LGTM.

[bruthig, 2016-08-02 17:00:32]

The CQ bit was unchecked by bruthig@chromium.org

[bruthig, 2016-08-02 17:00:33]

The CQ bit was checked by bruthig@chromium.org

[commit-bot: I haz the power, 2016-08-02 17:00:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 17:07:47]

Description was changed from

==========
Reland of "Apply Shelf/Dock opacity animations for the Material Design style."

The Shelf animates between the 3 ShelfBackgroundType's using 2
different animations; one uses BackgroundAnimator timers and
View::OnPaint() and the other uses a Layer to animate the
SHELF_BACKGROUND_MAXIMIZED opaque background.

This change centralizes the animation logic so they all stay in sync
and applies the opacity animations to the material design style
Shelf/Dock.

Eventually the ShelfBackgroundAnimator will be enhanced to animate
between colors instead of just alpha values.

Follow-up plans:
 - Use a single instance of the ShelfBackgroundAnimator.
 - Remove the |opaque_background_| from ShelfWidget and
   DockedBackgroundWidget.
 - Collapse the multiple BackgroundAnimators owned by the
   ShelfBackgroundAnimator into a single SlideAnimation.
 - Animate the MD AppList and Overflow buttons.

BUG=607037
==========

to

==========
Reland of "Apply Shelf/Dock opacity animations for the Material Design style."

The Shelf animates between the 3 ShelfBackgroundType's using 2
different animations; one uses BackgroundAnimator timers and
View::OnPaint() and the other uses a Layer to animate the
SHELF_BACKGROUND_MAXIMIZED opaque background.

This change centralizes the animation logic so they all stay in sync
and applies the opacity animations to the material design style
Shelf/Dock.

Eventually the ShelfBackgroundAnimator will be enhanced to animate
between colors instead of just alpha values.

Follow-up plans:
 - Use a single instance of the ShelfBackgroundAnimator.
 - Remove the |opaque_background_| from ShelfWidget and
   DockedBackgroundWidget.
 - Collapse the multiple BackgroundAnimators owned by the
   ShelfBackgroundAnimator into a single SlideAnimation.
 - Animate the MD AppList and Overflow buttons.

BUG=607037
==========

[commit-bot: I haz the power, 2016-08-02 17:07:48]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-02 17:09:37]

Description was changed from

==========
Reland of "Apply Shelf/Dock opacity animations for the Material Design style."

The Shelf animates between the 3 ShelfBackgroundType's using 2
different animations; one uses BackgroundAnimator timers and
View::OnPaint() and the other uses a Layer to animate the
SHELF_BACKGROUND_MAXIMIZED opaque background.

This change centralizes the animation logic so they all stay in sync
and applies the opacity animations to the material design style
Shelf/Dock.

Eventually the ShelfBackgroundAnimator will be enhanced to animate
between colors instead of just alpha values.

Follow-up plans:
 - Use a single instance of the ShelfBackgroundAnimator.
 - Remove the |opaque_background_| from ShelfWidget and
   DockedBackgroundWidget.
 - Collapse the multiple BackgroundAnimators owned by the
   ShelfBackgroundAnimator into a single SlideAnimation.
 - Animate the MD AppList and Overflow buttons.

BUG=607037
==========

to

==========
Reland of "Apply Shelf/Dock opacity animations for the Material Design style."

The Shelf animates between the 3 ShelfBackgroundType's using 2
different animations; one uses BackgroundAnimator timers and
View::OnPaint() and the other uses a Layer to animate the
SHELF_BACKGROUND_MAXIMIZED opaque background.

This change centralizes the animation logic so they all stay in sync
and applies the opacity animations to the material design style
Shelf/Dock.

Eventually the ShelfBackgroundAnimator will be enhanced to animate
between colors instead of just alpha values.

Follow-up plans:
 - Use a single instance of the ShelfBackgroundAnimator.
 - Remove the |opaque_background_| from ShelfWidget and
   DockedBackgroundWidget.
 - Collapse the multiple BackgroundAnimators owned by the
   ShelfBackgroundAnimator into a single SlideAnimation.
 - Animate the MD AppList and Overflow buttons.

BUG=607037

Committed: https://crrev.com/a2239af6304ceaac998a487cf3cd09e9c23ebfc5
Cr-Commit-Position: refs/heads/master@{#409211}
==========

[commit-bot: I haz the power, 2016-08-02 17:09:38]

Patchset 4 (id:??) landed as
https://crrev.com/a2239af6304ceaac998a487cf3cd09e9c23ebfc5
Cr-Commit-Position: refs/heads/master@{#409211}