Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2191333003: DevTools: Show/hide console -> 'console drawer' (Closed)

Created:
4 years, 4 months ago by paulirish
Modified:
4 years, 4 months ago
Reviewers:
chowse, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Show/hide console -> 'console drawer' Minor text change that clarifies our menu item for "show/hide console" is revealing the drawer in general. Users are confused that "show console" can reveal the "Search all files" functionality. BUG=522040 Committed: https://crrev.com/b99ab12179dd2961937729b7a0f5643fe574563f Cr-Commit-Position: refs/heads/master@{#408854}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
paulirish
wdyt, chris? bug for context
4 years, 4 months ago (2016-07-29 18:13:42 UTC) #3
chowse
On 2016/07/29 18:13:42, paulirish wrote: > wdyt, chris? > > bug for context "Show/hide console ...
4 years, 4 months ago (2016-07-29 18:56:04 UTC) #5
paulirish
sg. That right there was exactly my thought process as well.
4 years, 4 months ago (2016-07-29 19:19:58 UTC) #7
pfeldman
lgtm
4 years, 4 months ago (2016-07-30 00:30:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191333003/1
4 years, 4 months ago (2016-07-30 00:30:33 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-30 03:07:48 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-30 03:10:35 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b99ab12179dd2961937729b7a0f5643fe574563f
Cr-Commit-Position: refs/heads/master@{#408854}

Powered by Google App Engine
This is Rietveld 408576698