Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 219133004: Purge SkPurgeableMemoryBlock. (Closed)

Created:
6 years, 8 months ago by scroggo
Modified:
6 years, 8 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Purge SkPurgeableMemoryBlock. It was an experiment that is no longer used. Committed: http://code.google.com/p/skia/source/detail?r=14020

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -371 lines) Patch
M gyp/ports.gyp View 5 chunks +0 lines, -7 lines 0 comments Download
D src/lazy/SkPurgeableMemoryBlock.h View 1 chunk +0 lines, -94 lines 0 comments Download
D src/lazy/SkPurgeableMemoryBlock_common.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
D src/ports/SkPurgeableMemoryBlock_android.cpp View 1 chunk +0 lines, -110 lines 0 comments Download
D src/ports/SkPurgeableMemoryBlock_mac.cpp View 1 chunk +0 lines, -104 lines 0 comments Download
D src/ports/SkPurgeableMemoryBlock_none.cpp View 1 chunk +0 lines, -40 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
scroggo
6 years, 8 months ago (2014-03-31 15:34:25 UTC) #1
mtklein
How fitting. lgtm
6 years, 8 months ago (2014-03-31 15:36:52 UTC) #2
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 8 months ago (2014-03-31 15:41:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/219133004/1
6 years, 8 months ago (2014-03-31 15:41:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/219133004/1
6 years, 8 months ago (2014-04-01 21:33:00 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 21:49:24 UTC) #6
commit-bot: I haz the power
Failed to apply the patch. svn: Commit failed (details follow): svn: Caught signal
6 years, 8 months ago (2014-04-01 21:49:25 UTC) #7
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 8 months ago (2014-04-01 22:20:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/219133004/20001
6 years, 8 months ago (2014-04-01 22:20:38 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 23:51:08 UTC) #10
Message was sent while issue was closed. 
Change committed as 14020

Powered by Google App Engine
This is Rietveld 408576698