Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2191323004: Copy memory.fyi definitions to memory.full. (Closed)

Created:
4 years, 4 months ago by Jeffrey Yasskin
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, benwells, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Copy memory.fyi definitions to memory.full. BUG=597178 Committed: https://crrev.com/b747e4d1d27383021a0e3a726b1277e8803ea0ca Cr-Commit-Position: refs/heads/master@{#408805}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, --1 lines) Patch
A + testing/buildbot/chromium.memory.full.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/mb/mb_config.pyl View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Jeffrey Yasskin
I don't know how any of this works, but this seems like the right fix ...
4 years, 4 months ago (2016-07-29 18:55:04 UTC) #2
Nico
lgtm
4 years, 4 months ago (2016-07-29 21:33:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191323004/1
4 years, 4 months ago (2016-07-29 21:41:37 UTC) #6
Dirk Pranke
lgtm
4 years, 4 months ago (2016-07-29 23:43:46 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 23:48:36 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 23:50:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b747e4d1d27383021a0e3a726b1277e8803ea0ca
Cr-Commit-Position: refs/heads/master@{#408805}

Powered by Google App Engine
This is Rietveld 408576698