Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2191323002: Remove GrContext::applyGamma (Closed)

Created:
4 years, 4 months ago by robertphillips
Modified:
4 years, 4 months ago
Reviewers:
Brian Osman, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Clean up #

Total comments: 2

Patch Set 3 : Fix flushing in publishCanvas #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -76 lines) Patch
M include/gpu/GrContext.h View 1 chunk +0 lines, -9 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 2 3 chunks +14 lines, -17 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 chunk +0 lines, -34 lines 0 comments Download
M tests/ApplyGammaTest.cpp View 2 chunks +6 lines, -16 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
robertphillips
4 years, 4 months ago (2016-07-29 12:23:24 UTC) #4
bsalomon
lgtm https://codereview.chromium.org/2191323002/diff/20001/samplecode/SampleApp.cpp File samplecode/SampleApp.cpp (right): https://codereview.chromium.org/2191323002/diff/20001/samplecode/SampleApp.cpp#newcode349 samplecode/SampleApp.cpp:349: canvas->flush(); Move this canvas->flush() above win->present() at line ...
4 years, 4 months ago (2016-07-29 14:15:07 UTC) #9
robertphillips
https://codereview.chromium.org/2191323002/diff/20001/samplecode/SampleApp.cpp File samplecode/SampleApp.cpp (right): https://codereview.chromium.org/2191323002/diff/20001/samplecode/SampleApp.cpp#newcode349 samplecode/SampleApp.cpp:349: canvas->flush(); On 2016/07/29 14:15:07, bsalomon wrote: > Move this ...
4 years, 4 months ago (2016-07-29 14:39:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191323002/40001
4 years, 4 months ago (2016-07-29 15:27:28 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 15:28:28 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/1e8761809d76429961dac92f874e7e0a36a0e5c4

Powered by Google App Engine
This is Rietveld 408576698