Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2191313002: VM: Fix assertion checking number of active concurrent markers. (Closed)

Created:
4 years, 4 months ago by Vyacheslav Egorov (Google)
Modified:
4 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Fix assertion checking number of active concurrent markers. Add a barrier that ensures that no single marker rushes past assertion and increments num_busy while some other marker or the main thread are checking it. BUG=http://dartbug.com/26706 R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/59e67cc36d0877949719160de8959a11db4a8027

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M runtime/vm/gc_marker.cc View 3 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Vyacheslav Egorov (Google)
PTAL
4 years, 4 months ago (2016-07-29 12:01:18 UTC) #2
siva
lgtm
4 years, 4 months ago (2016-07-29 16:11:19 UTC) #4
Vyacheslav Egorov (Google)
4 years, 4 months ago (2016-08-01 09:08:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
59e67cc36d0877949719160de8959a11db4a8027 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698