Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 2191283002: Two visual fixes in the MD Clear Browsing Data dialog (Closed)

Created:
4 years, 4 months ago by msramek
Modified:
4 years, 4 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Two visual fixes in the MD Clear Browsing Data dialog 1. Change the footer color to that of secondary text (i.e. --paper-grey-600). 2. Replace the 12px bottom margin with padding, so that this 12px high area at the bottom becomes a part of the scrollable region. Screenshot: https://screenshot.googleplex.com/aodmwFZfdrq BUG=595580 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/16da7bacae1711efc00e78e41bd9794f679d5b56 Cr-Commit-Position: refs/heads/master@{#408817}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
msramek
Hi Dave, Please have a look! These two problems were pointed out in a recent ...
4 years, 4 months ago (2016-07-29 10:53:31 UTC) #8
dschuyler
lgtm
4 years, 4 months ago (2016-07-29 23:09:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191283002/1
4 years, 4 months ago (2016-07-30 00:25:44 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-30 00:29:22 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-07-30 00:32:46 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16da7bacae1711efc00e78e41bd9794f679d5b56
Cr-Commit-Position: refs/heads/master@{#408817}

Powered by Google App Engine
This is Rietveld 408576698