Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2191273002: Prevent crash when adding first account. (Closed)

Created:
4 years, 4 months ago by PEConn
Modified:
4 years, 4 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent crash when adding first account. BUG=630710 Committed: https://crrev.com/2880fef735e141bbb9776baec7ffafa4f6184ec5 Cr-Commit-Position: refs/heads/master@{#408612}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
PEConn
PTAL
4 years, 4 months ago (2016-07-29 09:14:27 UTC) #2
Bernhard Bauer
lgtm
4 years, 4 months ago (2016-07-29 09:52:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191273002/1
4 years, 4 months ago (2016-07-29 10:28:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 10:32:00 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 10:34:03 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2880fef735e141bbb9776baec7ffafa4f6184ec5
Cr-Commit-Position: refs/heads/master@{#408612}

Powered by Google App Engine
This is Rietveld 408576698