[DevTools] Fix text representation of IP addresses in SAN certificates

content/browser/devtools/protocol/network_handler.cc

Index: content/browser/devtools/protocol/network_handler.cc
diff --git a/content/browser/devtools/protocol/network_handler.cc b/content/browser/devtools/protocol/network_handler.cc
index ae9a58d7ce8a196e7ddc29895796a50a2c0ed3da..7f4638ce9f2fb6cd3eeee36141627409d822fafa 100644
--- a/content/browser/devtools/protocol/network_handler.cc
+++ b/content/browser/devtools/protocol/network_handler.cc
@@ -316,14 +316,22 @@ Response NetworkHandler::GetCertificateDetails(
   std::vector<std::string> ip_addrs;
   cert->GetSubjectAltName(&dns_names, &ip_addrs);
 
+  // IP addresses are in raw network bytes and must be converted to string form
+  std::vector<std::string> ip_addrs_string;
+  for (const std::string& ip : ip_addrs) {
+    net::IPAddress ip_addr(reinterpret_cast<const unsigned char*>(ip.c_str()),

[dgozman, 2016/08/01 23:28:04]

Let's be consistent with net::IPAddress and use "const uint8_t*" ?

+                           ip.length());
+    ip_addrs_string.push_back(ip_addr.ToString());
+  }
+
   *result = CertificateDetails::Create()
-                    ->set_subject(CertificateSubject::Create()
+                ->set_subject(CertificateSubject::Create()
                                   ->set_name(name)
                                   ->set_san_dns_names(dns_names)
-                                  ->set_san_ip_addresses(ip_addrs))
-                    ->set_issuer(issuer)
-                    ->set_valid_from(valid_from.ToDoubleT())
-                    ->set_valid_to(valid_to.ToDoubleT());
+                                  ->set_san_ip_addresses(ip_addrs_string))
+                ->set_issuer(issuer)
+                ->set_valid_from(valid_from.ToDoubleT())
+                ->set_valid_to(valid_to.ToDoubleT());
   return Response::OK();
 }