Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(939)

Unified Diff: third_party/WebKit/Source/platform/testing/PaintPrinters.cpp

Issue 2191233002: Add platform/geometry pretty printers for logging and testing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adjust tests to work around uninteresting cross-platform differences Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/testing/PaintPrinters.cpp
diff --git a/third_party/WebKit/Source/platform/testing/PaintPrinters.cpp b/third_party/WebKit/Source/platform/testing/PaintPrinters.cpp
index 8cd0db3ff0ce751ac912a7db9e59b467b8929bcf..ef2a6d77f15559ed4da911d78e7cbe4452ea4acf 100644
--- a/third_party/WebKit/Source/platform/testing/PaintPrinters.cpp
+++ b/third_party/WebKit/Source/platform/testing/PaintPrinters.cpp
@@ -33,7 +33,7 @@ static void PrintPointer(const void* ptr, std::ostream& os)
void PrintTo(const ClipPaintPropertyNode& node, std::ostream* os)
{
*os << "ClipPaintPropertyNode(clip=";
- PrintTo(node.clipRect(), os);
+ *os << node.clipRect();
*os << ", localTransformSpace=";
PrintPointer(node.localTransformSpace(), *os);
*os << ", parent=";
@@ -60,7 +60,7 @@ void PrintTo(const PaintChunk& chunk, std::ostream* os)
*os << ", props=";
PrintTo(chunk.properties, os);
*os << ", bounds=";
- PrintTo(chunk.bounds, os);
+ *os << chunk.bounds;
*os << ", knownToBeOpaque=" << chunk.knownToBeOpaque << ")";
}
@@ -102,7 +102,7 @@ void PrintTo(const TransformPaintPropertyNode& transformPaintProperty, std::ostr
*os << "TransformPaintPropertyNode(matrix=";
PrintTo(transformPaintProperty.matrix(), os);
*os << ", origin=";
- PrintTo(transformPaintProperty.origin(), os);
+ *os << transformPaintProperty.origin();
*os << ")";
}

Powered by Google App Engine
This is Rietveld 408576698