Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: third_party/WebKit/Source/platform/geometry/LayoutRect.h

Issue 2191233002: Add platform/geometry pretty printers for logging and testing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adjust tests to work around uninteresting cross-platform differences Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/geometry/LayoutRect.h
diff --git a/third_party/WebKit/Source/platform/geometry/LayoutRect.h b/third_party/WebKit/Source/platform/geometry/LayoutRect.h
index 6811d62a80ecb1dc5258783ace3f021f806e728b..326cceeae29fea18504f7de355f4dbc743524f5c 100644
--- a/third_party/WebKit/Source/platform/geometry/LayoutRect.h
+++ b/third_party/WebKit/Source/platform/geometry/LayoutRect.h
@@ -201,12 +201,6 @@ public:
return infiniteIntRect;
}
-#ifndef NDEBUG
- // Prints the rect to the screen.
- void show(bool showRawValue = false) const;
- String toString() const;
-#endif
-
private:
LayoutPoint m_location;
LayoutSize m_size;
@@ -272,9 +266,7 @@ inline IntRect pixelSnappedIntRect(LayoutPoint location, LayoutSize size)
return IntRect(roundedIntPoint(location), pixelSnappedIntSize(size, location));
}
-// Redeclared here to avoid ODR issues.
-// See platform/testing/GeometryPrinters.h.
-void PrintTo(const LayoutRect&, std::ostream*);
+PLATFORM_EXPORT std::ostream& operator<<(std::ostream&, const LayoutRect&);
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698