third_party/WebKit/Source/platform/geometry/IntSize.cpp - Issue 2191233002: Add platform/geometry pretty printers for logging and testing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/geometry/IntSize.cpp

Issue 2191233002: Add platform/geometry pretty printers for logging and testing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adjust tests to work around uninteresting cross-platform differences Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/geometry/IntRectTest.cpp ('K') | « third_party/WebKit/Source/platform/geometry/IntSize.h ('k') | third_party/WebKit/Source/platform/geometry/LayoutPoint.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/geometry/IntSize.cpp

diff --git a/third_party/WebKit/Source/platform/geometry/IntSize.cpp b/third_party/WebKit/Source/platform/geometry/IntSize.cpp

index cadeac588230c9e36070cc162a2cd2cd4d143f57..34168616202d0c5544da06fc466db79633f770bf 100644

--- a/third_party/WebKit/Source/platform/geometry/IntSize.cpp

+++ b/third_party/WebKit/Source/platform/geometry/IntSize.cpp

@@ -5,7 +5,7 @@

#include "platform/geometry/IntSize.h"

#include "ui/gfx/geometry/size.h"

-#include "wtf/text/WTFString.h"

+#include <ostream> // NOLINT

namespace blink {

@@ -14,11 +14,12 @@ IntSize::operator gfx::Size() const

return gfx::Size(width(), height());

}

-#ifndef NDEBUG

-String IntSize::toString() const

+std::ostream& operator<<(std::ostream& os, const IntSize& size)

{

- return String::format("%dx%d", width(), height());

+ os << "IntSize("

+ << "width=" << size.width() << ", "

+ << "height=" << size.height() << ")";

+ return os;

}

-#endif

} // namespace blink