Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: third_party/WebKit/Source/platform/geometry/FloatSize.cpp

Issue 2191233002: Add platform/geometry pretty printers for logging and testing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adjust tests to work around uninteresting cross-platform differences Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/geometry/FloatSize.cpp
diff --git a/third_party/WebKit/Source/platform/geometry/FloatSize.cpp b/third_party/WebKit/Source/platform/geometry/FloatSize.cpp
index 38c3375fff957d4bcbb4be9aa07d068e022b27cf..fba58ad1e89f37c53ac1f460944f3097f25e8845 100644
--- a/third_party/WebKit/Source/platform/geometry/FloatSize.cpp
+++ b/third_party/WebKit/Source/platform/geometry/FloatSize.cpp
@@ -29,9 +29,9 @@
#include "platform/FloatConversion.h"
#include "platform/geometry/IntSize.h"
#include "platform/geometry/LayoutSize.h"
-#include "wtf/text/WTFString.h"
#include <limits>
#include <math.h>
+#include <ostream> // NOLINT
namespace blink {
@@ -61,11 +61,12 @@ FloatSize FloatSize::narrowPrecision(double width, double height)
return FloatSize(narrowPrecisionToFloat(width), narrowPrecisionToFloat(height));
}
-#ifndef NDEBUG
-String FloatSize::toString() const
+std::ostream& operator<<(std::ostream& os, const FloatSize& size)
{
- return String::format("%fx%f", width(), height());
+ os << "FloatSize("
+ << "width=" << size.width() << ", "
+ << "height=" << size.height() << ")";
+ return os;
}
-#endif
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698