Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: third_party/WebKit/Source/platform/geometry/FloatRoundedRect.h

Issue 2191233002: Add platform/geometry pretty printers for logging and testing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adjust tests to work around uninteresting cross-platform differences Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/geometry/FloatRoundedRect.h
diff --git a/third_party/WebKit/Source/platform/geometry/FloatRoundedRect.h b/third_party/WebKit/Source/platform/geometry/FloatRoundedRect.h
index f3ccbbfdc548551a91ad5b0e39ad4589e858b54c..efb7d474dc5acb1f9ac476b3b4d9782da374e44c 100644
--- a/third_party/WebKit/Source/platform/geometry/FloatRoundedRect.h
+++ b/third_party/WebKit/Source/platform/geometry/FloatRoundedRect.h
@@ -86,11 +86,6 @@ public:
void includeLogicalEdges(const Radii& edges, bool isHorizontal, bool includeLogicalLeftEdge, bool includeLogicalRightEdge);
-#ifndef NDEBUG
- // Prints debugging information.
- void show() const;
-#endif
-
private:
FloatSize m_topLeft;
FloatSize m_topRight;
@@ -152,11 +147,6 @@ public:
void adjustRadii();
bool isRenderable() const;
-#ifndef NDEBUG
- // Prints debugging information.
- void show() const;
-#endif
-
// Constrains the radii to be no more than the size of rect(); radii outside of this range are not
// defined.
// In addition, the radii of the corners are floored to the nearest integer.
@@ -207,10 +197,8 @@ inline bool operator==(const FloatRoundedRect& a, const FloatRoundedRect& b)
return a.rect() == b.rect() && a.getRadii() == b.getRadii();
}
-// Redeclared here to avoid ODR issues.
-// See platform/testing/GeometryPrinters.h.
-void PrintTo(const FloatRoundedRect&, std::ostream*);
-void PrintTo(const FloatRoundedRect::Radii&, std::ostream*);
+PLATFORM_EXPORT std::ostream& operator<<(std::ostream&, const FloatRoundedRect::Radii&);
+PLATFORM_EXPORT std::ostream& operator<<(std::ostream&, const FloatRoundedRect&);
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698