third_party/WebKit/Source/platform/geometry/IntRect.cpp - Issue 2191233002: Add platform/geometry pretty printers for logging and testing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/geometry/IntRect.cpp

Issue 2191233002: Add platform/geometry pretty printers for logging and testing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fastest logging this side of the mississippi Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/geometry/FloatRoundedRectTest.cpp ('K') | « third_party/WebKit/Source/platform/geometry/IntRect.h ('k') | third_party/WebKit/Source/platform/geometry/IntRectTest.cpp » ('j') | third_party/WebKit/Source/platform/geometry/LayoutRect.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/geometry/IntRect.cpp

diff --git a/third_party/WebKit/Source/platform/geometry/IntRect.cpp b/third_party/WebKit/Source/platform/geometry/IntRect.cpp

index 0539c8e88aae271dc0373421969fb45d2cc611a1..f6fb193848f63bafd781b4fc6f5b46d3ce04665f 100644

--- a/third_party/WebKit/Source/platform/geometry/IntRect.cpp

+++ b/third_party/WebKit/Source/platform/geometry/IntRect.cpp

@@ -187,17 +187,11 @@ IntRect unionRectEvenIfEmpty(const Vector<IntRect>& rects)

return result;

}

-#ifndef NDEBUG

- // Prints the rect to the screen.

-void IntRect::show() const

- LayoutRect(*this).show();

String IntRect::toString() const

{

- return String::format("%s %s", location().toString().ascii().data(), size().toString().ascii().data());

+ return String::format("%s %s",

+ location().toString().ascii().data(),

+ size().toString().ascii().data());

}

-#endif

} // namespace blink