Add platform/geometry pretty printers for logging and testing

third_party/WebKit/Source/platform/geometry/FloatQuad.cpp

Index: third_party/WebKit/Source/platform/geometry/FloatQuad.cpp
diff --git a/third_party/WebKit/Source/platform/geometry/FloatQuad.cpp b/third_party/WebKit/Source/platform/geometry/FloatQuad.cpp
index 3759aa67fff91a2a20e4af7ba4418b90c2a92f63..dfb085f799155eb44ee7508e8d7ab012c943044e 100644
--- a/third_party/WebKit/Source/platform/geometry/FloatQuad.cpp
+++ b/third_party/WebKit/Source/platform/geometry/FloatQuad.cpp
@@ -31,14 +31,11 @@
 #include "platform/geometry/FloatQuad.h"
 
 #include "third_party/skia/include/core/SkPoint.h"
+#include "wtf/text/WTFString.h"

[wkorman, 2016/08/19 22:18:44]

I think jbroman@ had suggested just including wtf/Forward.h whenever we need
this, as standard approach.

[pdr., 2016/08/19 23:21:15]

We talked offline about this and decided not to pursue the Forward approach
which is more for header files.

 #include <algorithm>
 #include <cmath>
 #include <limits>
 
-#ifndef NDEBUG
-#include <stdio.h>
-#endif
-
 namespace blink {
 
 static inline float min4(float a, float b, float c, float d)
@@ -252,11 +249,13 @@ bool FloatQuad::isCounterclockwise() const
     return determinant(m_p2 - m_p1, m_p3 - m_p2) < 0;
 }
 
-#ifndef NDEBUG
-void FloatQuad::show() const
+String FloatQuad::toString() const
 {
-    fprintf(stderr, "FloatQuad: [p1=(%f,%f), p2=(%f,%f), p3=(%f,%f), p4=(%f,%f))]\n", m_p1.x(), m_p1.y(), m_p2.x(), m_p2.y(), m_p3.x(), m_p3.y(), m_p4.x(), m_p4.y());
+    return String::format("%s; %s; %s; %s",

[wkorman, 2016/08/19 22:18:44]

FloatQuadTest? I ask because I wondered whether maybe we want to surround the
points with parens, so I went to see what we do. Probably don't need the parens.
I'd vote for simple unit test for all toString() methods, so throughout change,
I think we're only missing a few (Box, Quad variants).

[pdr., 2016/08/19 23:21:15]

Done, just added FloatQuadTest and FloatBoxTest to the existing LayoutRectTest,
IntRectTest, and FloatRectTest. Each of the Rect tests also tests the point and
size versions.

+        m_p1.toString().ascii().data(),
+        m_p2.toString().ascii().data(),
+        m_p3.toString().ascii().data(),
+        m_p4.toString().ascii().data());
 }
-#endif
 
 } // namespace blink