Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 219123002: Read the default min-width value from the UA style sheets (Closed)

Created:
6 years, 8 months ago by kenneth.r.christiansen
Modified:
6 years, 8 months ago
CC:
blink-reviews, kenneth.christiansen, jamesr, sof, eae+blinkwatch, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org, Inactive, rwlbuis
Visibility:
Public.

Description

Read the default min-width value from the UA style sheets When enabling the viewport meta tag the default min layout width is hardcoded to 980. Now we get that value from the UA style sheets instead making it extend-to-zoom on desktop when enabled. The former setting has been removed. BUG=358687 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170655

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -55 lines) Patch
M Source/core/css/resolver/ViewportStyleResolver.cpp View 1 2 3 2 chunks +4 lines, -6 lines 0 comments Download
M Source/core/dom/Document.h View 3 chunks +4 lines, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/dom/ViewportDescription.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ViewportDescription.cpp View 1 2 1 chunk +21 lines, -3 lines 0 comments Download
M Source/core/frame/Settings.in View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/html/HTMLMetaElement-in.cpp View 1 2 2 chunks +0 lines, -15 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/web/PageScaleConstraintsSet.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M Source/web/PageScaleConstraintsSet.cpp View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M Source/web/WebSettingsImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 2 2 chunks +11 lines, -5 lines 0 comments Download
M Source/web/tests/ViewportTest.cpp View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 2 8 chunks +20 lines, -0 lines 0 comments Download
M Source/web/tests/data/no_viewport_tag.html View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M public/web/WebSettings.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 26 (0 generated)
kenneth.r.christiansen
6 years, 8 months ago (2014-03-31 10:23:52 UTC) #1
kenneth.r.christiansen
6 years, 8 months ago (2014-03-31 12:37:02 UTC) #2
kenneth.r.christiansen
6 years, 8 months ago (2014-03-31 12:37:31 UTC) #3
apavlov
https://codereview.chromium.org/219123002/diff/1/Source/core/dom/Document.cpp File Source/core/dom/Document.cpp (right): https://codereview.chromium.org/219123002/diff/1/Source/core/dom/Document.cpp#newcode3033 Source/core/dom/Document.cpp:3033: // The UA defined min-width is used by the ...
6 years, 8 months ago (2014-03-31 16:47:18 UTC) #4
kenneth.r.christiansen
https://codereview.chromium.org/219123002/diff/1/Source/core/dom/Document.cpp File Source/core/dom/Document.cpp (right): https://codereview.chromium.org/219123002/diff/1/Source/core/dom/Document.cpp#newcode3033 Source/core/dom/Document.cpp:3033: // The UA defined min-width is used by the ...
6 years, 8 months ago (2014-03-31 20:37:08 UTC) #5
aelias_OOO_until_Jul13
lgtm
6 years, 8 months ago (2014-04-01 00:13:41 UTC) #6
kenneth.r.christiansen
The CQ bit was checked by kenneth.r.christiansen@intel.com
6 years, 8 months ago (2014-04-01 08:23:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenneth.r.christiansen@intel.com/219123002/20001
6 years, 8 months ago (2014-04-01 08:23:11 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 08:32:23 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 8 months ago (2014-04-01 08:32:23 UTC) #10
jochen (gone - plz use gerrit)
can you please reference the tracking bug in the CL description (or file one if ...
6 years, 8 months ago (2014-04-01 11:26:05 UTC) #11
kenneth.r.christiansen
On 2014/04/01 11:26:05, jochen wrote: > can you please reference the tracking bug in the ...
6 years, 8 months ago (2014-04-01 17:37:31 UTC) #12
jochen (gone - plz use gerrit)
lgtm
6 years, 8 months ago (2014-04-02 09:41:35 UTC) #13
kenneth.r.christiansen
The CQ bit was checked by kenneth.r.christiansen@intel.com
6 years, 8 months ago (2014-04-02 09:42:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenneth.r.christiansen@intel.com/219123002/60001
6 years, 8 months ago (2014-04-02 09:43:01 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 12:41:38 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-02 12:41:38 UTC) #17
kenneth.r.christiansen
The CQ bit was checked by kenneth.r.christiansen@intel.com
6 years, 8 months ago (2014-04-02 12:45:10 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenneth.r.christiansen@intel.com/219123002/60001
6 years, 8 months ago (2014-04-02 12:45:15 UTC) #19
kenneth.r.christiansen
06:07:22.969 19574 ASSERTION FAILED: currentDoc->isActive() 06:07:22.969 19574 ../../third_party/WebKit/Source/core/dom/FullscreenElementStack.cpp(284) : void WebCore::FullscreenElementStack::webkitExitFullscreen() Seems unrelated
6 years, 8 months ago (2014-04-02 13:39:02 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 14:03:34 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-02 14:03:35 UTC) #22
kenneth.r.christiansen
Landing with NOTRY. https://codereview.chromium.org/222023003 already exists for the unrelated fullscreen failures.
6 years, 8 months ago (2014-04-02 14:08:10 UTC) #23
kenneth.r.christiansen
The CQ bit was checked by kenneth.r.christiansen@intel.com
6 years, 8 months ago (2014-04-02 14:08:48 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenneth.r.christiansen@intel.com/219123002/60001
6 years, 8 months ago (2014-04-02 14:08:57 UTC) #25
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 14:09:25 UTC) #26
Message was sent while issue was closed. 
Change committed as 170655

Powered by Google App Engine
This is Rietveld 408576698