third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/dom-breakpoints.html - Issue 2191183003: DevTools: extract model from DOMBreakpointsSidebarPane

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/dom-breakpoints.html

Issue 2191183003: DevTools: extract model from DOMBreakpointsSidebarPane (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: minor style nits Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/dom-breakpoints-expected.txt » ('j') | third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/dom-breakpoints.html

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/dom-breakpoints.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/dom-breakpoints.html

index 40de3d5174624c8c5f9d4203adc44b1de4e53806..821d380094b769dca28ea43cb6dd8e2aaec725da 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/dom-breakpoints.html

+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/dom-breakpoints.html

@@ -153,7 +153,14 @@ function test()

function step2(callFrames)

{

pane._removeBreakpoint(rootElement, pane._breakpointTypes.AttributeModified);

- next();

+ InspectorTest.addResult("Ensure the breakpoint is actually removed.");

+ InspectorTest.evaluateInPagePromise("modifyAttribute('rootElement', 'data-test', 'foo')").then(step3);

+ InspectorTest.addResult("Modify rootElement data-test attribute.");

+ }

+ function step3()

+ {

+ InspectorTest.waitUntilResumed(next);

}