Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: components/offline_pages/offline_page_model_impl.cc

Issue 2191183002: [Offline Pages] Add expiration in internal log. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/offline_pages/offline_page_model_event_logger_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/offline_pages/offline_page_model_impl.cc
diff --git a/components/offline_pages/offline_page_model_impl.cc b/components/offline_pages/offline_page_model_impl.cc
index f08f1feefb1e2accacc8d5f76395a994a43ffd2f..a4d63b2595aa929393db9452dd9373ae7f60891c 100644
--- a/components/offline_pages/offline_page_model_impl.cc
+++ b/components/offline_pages/offline_page_model_impl.cc
@@ -664,6 +664,7 @@ void OfflinePageModelImpl::OnExpirePageDone(int64_t offline_id,
if (iter != offline_pages_.end()) {
iter->second.expiration_time = expiration_time;
ClientId client_id = iter->second.client_id;
+ offline_event_logger_.RecordPageExpired(std::to_string(offline_id));
base::HistogramBase* histogram = base::Histogram::FactoryGet(
AddHistogramSuffix(client_id, "OfflinePages.ExpirePage.PageLifetime"),
1, base::TimeDelta::FromDays(30).InMinutes(), 50,
« no previous file with comments | « components/offline_pages/offline_page_model_event_logger_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698