Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: components/offline_pages/offline_page_model_event_logger_unittest.cc

Issue 2191183002: [Offline Pages] Add expiration in internal log. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model_event_logger_unittest.cc
diff --git a/components/offline_pages/offline_page_model_event_logger_unittest.cc b/components/offline_pages/offline_page_model_event_logger_unittest.cc
index c5510d42e2185dc7739360007c75bbe28bbdfccf..1cc6fa26862607b77de9e7a48d7f0d87a6a265b1 100644
--- a/components/offline_pages/offline_page_model_event_logger_unittest.cc
+++ b/components/offline_pages/offline_page_model_event_logger_unittest.cc
@@ -17,6 +17,7 @@ const int kTimeLength = 21;
const char kPageSaved[] =
"http://www.wikipedia.org is saved at last_n with id foobar";
const char kPageDeleted[] = "Page with ID foobar has been deleted";
+const char kPageExpired[] = "Page with ID foobar has been expired";
const char kRecordStoreClearError[] = "Offline store clear failed";
const char kRecordStoreCleared[] = "Offline store cleared";
const char kRecordStoreReloadError[] =
@@ -32,14 +33,16 @@ TEST(OfflinePageModelEventLoggerTest, RecordsWhenLoggingIsOn) {
logger.RecordStoreCleared();
logger.RecordPageSaved(kNamespace, kUrl, kOfflineId);
logger.RecordPageDeleted(kOfflineId);
+ logger.RecordPageExpired(kOfflineId);
logger.RecordStoreClearError();
logger.RecordStoreReloadError();
logger.GetLogs(&log);
- EXPECT_EQ(5u, log.size());
- EXPECT_EQ(std::string(kRecordStoreCleared), log[4].substr(kTimeLength));
- EXPECT_EQ(std::string(kPageSaved), log[3].substr(kTimeLength));
- EXPECT_EQ(std::string(kPageDeleted), log[2].substr(kTimeLength));
+ EXPECT_EQ(6u, log.size());
+ EXPECT_EQ(std::string(kRecordStoreCleared), log[5].substr(kTimeLength));
+ EXPECT_EQ(std::string(kPageSaved), log[4].substr(kTimeLength));
+ EXPECT_EQ(std::string(kPageDeleted), log[3].substr(kTimeLength));
+ EXPECT_EQ(std::string(kPageExpired), log[2].substr(kTimeLength));
EXPECT_EQ(std::string(kRecordStoreClearError), log[1].substr(kTimeLength));
EXPECT_EQ(std::string(kRecordStoreReloadError), log[0].substr(kTimeLength));
}
@@ -52,6 +55,7 @@ TEST(OfflinePageModelEventLoggerTest, DoesNotRecordWhenLoggingIsOff) {
logger.RecordStoreCleared();
logger.RecordPageSaved(kNamespace, kUrl, kOfflineId);
logger.RecordPageDeleted(kOfflineId);
+ logger.RecordPageExpired(kOfflineId);
logger.RecordStoreClearError();
logger.RecordStoreReloadError();
logger.GetLogs(&log);
« no previous file with comments | « components/offline_pages/offline_page_model_event_logger.cc ('k') | components/offline_pages/offline_page_model_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698