Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 2191183002: [Offline Pages] Add expiration in internal log. (Closed)

Created:
4 years, 4 months ago by romax
Modified:
4 years, 4 months ago
Reviewers:
michaelpg, dewittj
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Add expiration in internal log. Add expired as a logged event in offline-internal page. BUG=NONE Committed: https://crrev.com/a748f8c31ecdc002a3e5abd3738377135a592239 Cr-Commit-Position: refs/heads/master@{#408730}

Patch Set 1 #

Patch Set 2 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M chrome/browser/ui/webui/offline_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/offline_pages/offline_page_model_event_logger.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/offline_pages/offline_page_model_event_logger.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/offline_pages/offline_page_model_event_logger_unittest.cc View 1 3 chunks +8 lines, -4 lines 0 comments Download
M components/offline_pages/offline_page_model_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
romax
Simple changes. PTAL, Thanks! michaelpg@chromium.org: Please review changes in webui/ dewittj@chromium.org: Please review changes in ...
4 years, 4 months ago (2016-07-29 01:09:49 UTC) #2
michaelpg
c/b/ui/webui lgtm
4 years, 4 months ago (2016-07-29 06:41:58 UTC) #7
dewittj
lgtm
4 years, 4 months ago (2016-07-29 18:10:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191183002/20001
4 years, 4 months ago (2016-07-29 19:29:46 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-29 19:36:22 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 19:37:59 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a748f8c31ecdc002a3e5abd3738377135a592239
Cr-Commit-Position: refs/heads/master@{#408730}

Powered by Google App Engine
This is Rietveld 408576698