Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2435)

Unified Diff: ash/shelf/shelf_view.cc

Issue 2191153002: Revert of Replaced BackgroundAnimator with ShelfBackgroundAnimator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/shelf/shelf_view.h ('k') | ash/shelf/shelf_view_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shelf/shelf_view.cc
diff --git a/ash/shelf/shelf_view.cc b/ash/shelf/shelf_view.cc
index ea03a1ac6be877e61baf06cfca1e6947c822ab83..7e3119ed71ba7ce9c57122915049e4fc51b405e1 100644
--- a/ash/shelf/shelf_view.cc
+++ b/ash/shelf/shelf_view.cc
@@ -14,7 +14,6 @@
#include "ash/common/shelf/overflow_bubble.h"
#include "ash/common/shelf/overflow_bubble_view.h"
#include "ash/common/shelf/overflow_button.h"
-#include "ash/common/shelf/shelf_background_animator.h"
#include "ash/common/shelf/shelf_button.h"
#include "ash/common/shelf/shelf_constants.h"
#include "ash/common/shelf/shelf_delegate.h"
@@ -361,8 +360,7 @@
ShelfView::ShelfView(ShelfModel* model,
ShelfDelegate* delegate,
WmShelf* wm_shelf,
- Shelf* shelf,
- ShelfBackgroundAnimator* background_animator)
+ Shelf* shelf)
: model_(model),
delegate_(delegate),
wm_shelf_(wm_shelf),
@@ -390,8 +388,7 @@
main_shelf_(nullptr),
dragged_off_from_overflow_to_shelf_(false),
is_repost_event_on_same_item_(false),
- last_pressed_index_(-1),
- background_animator_(background_animator) {
+ last_pressed_index_(-1) {
DCHECK(model_);
DCHECK(delegate_);
DCHECK(wm_shelf_);
@@ -404,8 +401,6 @@
ShelfView::~ShelfView() {
bounds_animator_->RemoveObserver(this);
model_->RemoveObserver(this);
- if (background_animator_)
- background_animator_->RemoveObserver(this);
}
void ShelfView::Init() {
@@ -422,9 +417,6 @@
overflow_button_->set_context_menu_controller(this);
ConfigureChildView(overflow_button_);
AddChildView(overflow_button_);
-
- if (background_animator_)
- background_animator_->AddObserver(this);
// We'll layout when our bounds change.
}
@@ -1378,7 +1370,7 @@
overflow_bubble_.reset(new OverflowBubble(wm_shelf_));
ShelfView* overflow_view =
- new ShelfView(model_, delegate_, wm_shelf_, shelf_, nullptr);
+ new ShelfView(model_, delegate_, wm_shelf_, shelf_);
overflow_view->overflow_mode_ = true;
overflow_view->Init();
overflow_view->set_owner_overflow_bubble(overflow_bubble_.get());
@@ -1553,11 +1545,6 @@
->GetNativeWindow();
if (gesture_handler_.ProcessGestureEvent(*event, target_window))
event->StopPropagation();
-}
-
-void ShelfView::UpdateShelfItemBackground(int alpha) {
- GetAppListButton()->SetBackgroundAlpha(alpha);
- overflow_button_->SetBackgroundAlpha(alpha);
}
void ShelfView::ShelfItemAdded(int model_index) {
« no previous file with comments | « ash/shelf/shelf_view.h ('k') | ash/shelf/shelf_view_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698