components/test_runner/web_frame_test_client.cc - Issue 2191143002: Opt-in stripping of line numbers from console messages of layout tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/web_frame_test_client.cc

Issue 2191143002: Opt-in stripping of line numbers from console messages of layout tests. Base URL: https://chromium.googlesource.com/chromium/src.git@csp-reporting-ipcs

Patch Set: Rebasing... Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/test_runner/web_frame_test_client.cc

diff --git a/components/test_runner/web_frame_test_client.cc b/components/test_runner/web_frame_test_client.cc

index df4b4b729d78deea37e98592bfb3d51b9dfe1b86..9a6f64d69022a2e7fd6ed2f4a01f1c48ec2629a2 100644

--- a/components/test_runner/web_frame_test_client.cc

+++ b/components/test_runner/web_frame_test_client.cc

@@ -688,7 +688,7 @@ void WebFrameTestClient::didAddMessageToConsole(

level = "MESSAGE";

}

delegate_->PrintMessage(std::string("CONSOLE ") + level + ": ");

- if (source_line) {

+ if (source_line && test_runner_->shouldDumpConsoleLineNumbers()) {

delegate_->PrintMessage(base::StringPrintf("line %d: ", source_line));

}

if (!message.text.isEmpty()) {

« no previous file with comments | « components/test_runner/test_runner.cc ('k') | third_party/WebKit/LayoutTests/FlagExpectations/site-per-process » ('j') | no next file with comments »