Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2191053002: aw: Fix WebViewDatabaseAdapter threading (Closed)

Created:
4 years, 4 months ago by boliu
Modified:
4 years, 4 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aw: Fix WebViewDatabaseAdapter threading Hope to UI thread where needed. BUG=630709 Committed: https://crrev.com/cd9720621937c9779b54cf8256165dda2385b6f3 Cr-Commit-Position: refs/heads/master@{#408653}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -3 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java View 1 1 chunk +1 line, -1 line 0 comments Download
M android_webview/glue/java/src/com/android/webview/chromium/WebViewDatabaseAdapter.java View 3 chunks +52 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
boliu
part 3
4 years, 4 months ago (2016-07-29 00:35:22 UTC) #2
Torne
https://codereview.chromium.org/2191053002/diff/1/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java File android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java (right): https://codereview.chromium.org/2191053002/diff/1/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java#newcode542 android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java:542: this, runOnUiThreadBlocking(new Callable<HttpAuthDatabase>() { Isn't this going to have ...
4 years, 4 months ago (2016-07-29 11:26:52 UTC) #3
boliu
https://codereview.chromium.org/2191053002/diff/1/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java File android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java (right): https://codereview.chromium.org/2191053002/diff/1/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java#newcode542 android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java:542: this, runOnUiThreadBlocking(new Callable<HttpAuthDatabase>() { On 2016/07/29 11:26:51, Torne wrote: ...
4 years, 4 months ago (2016-07-29 13:25:05 UTC) #4
boliu
rebased
4 years, 4 months ago (2016-07-29 15:56:05 UTC) #5
Torne
lgtm
4 years, 4 months ago (2016-07-29 15:56:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191053002/20001
4 years, 4 months ago (2016-07-29 15:57:52 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-29 16:29:01 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 16:34:28 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cd9720621937c9779b54cf8256165dda2385b6f3
Cr-Commit-Position: refs/heads/master@{#408653}

Powered by Google App Engine
This is Rietveld 408576698