Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2191033002: Split ServiceRegistryAndroid into InterfaceRegistryAndroid and InterfaceProviderAndroid (Closed)

Created:
4 years, 4 months ago by Ben Goodger (Google)
Modified:
4 years, 4 months ago
Reviewers:
no sievers
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, Peter Beverloo, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split ServiceRegistryAndroid into InterfaceRegistryAndroid and InterfaceProviderAndroid This has been done in the C++ layer already, and I'd like to do this on the Java side as well since a single object doesn't always want to hold both the registry and the provider objects. R=sievers@chromium.org BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/a2bfa904bfbfd746e4e61a7be05ca89c8b2b90f2 Cr-Commit-Position: refs/heads/master@{#408707}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 2

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+598 lines, -909 lines) Patch
A + chrome/android/java/src/org/chromium/chrome/browser/mojo/ChromeInterfaceRegistrar.java View 1 chunk +6 lines, -6 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/mojo/ChromeServiceRegistrar.java View 1 chunk +0 lines, -22 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestFactory.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java_sources.gni View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/android/mojo/chrome_interface_registrar_android.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + chrome/browser/android/mojo/chrome_interface_registrar_android.cc View 1 2 3 2 chunks +7 lines, -8 lines 0 comments Download
D chrome/browser/android/mojo/chrome_service_registrar_android.h View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/android/mojo/chrome_service_registrar_android.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/android/browser_jni_registrar.cc View 1 2 3 4 3 chunks +8 lines, -4 lines 0 comments Download
A content/browser/android/interface_provider_android_impl.h View 1 chunk +43 lines, -0 lines 0 comments Download
A content/browser/android/interface_provider_android_impl.cc View 1 2 1 chunk +66 lines, -0 lines 0 comments Download
A content/browser/android/interface_registry_android_impl.h View 1 chunk +48 lines, -0 lines 0 comments Download
A content/browser/android/interface_registry_android_impl.cc View 1 2 1 chunk +104 lines, -0 lines 0 comments Download
D content/browser/android/service_registry_android_impl.h View 1 chunk +0 lines, -55 lines 0 comments Download
D content/browser/android/service_registry_android_impl.cc View 1 chunk +0 lines, -117 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 3 4 2 chunks +8 lines, -9 lines 0 comments Download
A content/browser/mojo/interface_registrar_android.h View 1 chunk +26 lines, -0 lines 0 comments Download
A + content/browser/mojo/interface_registrar_android.cc View 1 1 chunk +10 lines, -10 lines 0 comments Download
M content/browser/mojo/mojo_child_connection.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/mojo/mojo_child_connection.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D content/browser/mojo/service_registrar_android.h View 1 chunk +0 lines, -25 lines 0 comments Download
D content/browser/mojo/service_registrar_android.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 3 chunks +8 lines, -5 lines 0 comments Download
M content/content_jni.gypi View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M content/public/android/BUILD.gn View 1 2 3 4 4 chunks +4 lines, -3 lines 0 comments Download
A content/public/android/java/src/org/chromium/content/browser/InterfaceProvider.java View 1 2 1 chunk +44 lines, -0 lines 0 comments Download
A + content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrar.java View 2 chunks +7 lines, -7 lines 0 comments Download
A + content/public/android/java/src/org/chromium/content/browser/InterfaceRegistry.java View 1 2 3 chunks +18 lines, -26 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/ServiceRegistrar.java View 1 chunk +0 lines, -66 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/ServiceRegistry.java View 1 chunk +0 lines, -85 lines 0 comments Download
A + content/public/android/javatests/src/org/chromium/content/browser/InterfaceRegistryTest.java View 4 chunks +27 lines, -26 lines 0 comments Download
D content/public/android/javatests/src/org/chromium/content/browser/ServiceRegistryTest.java View 1 chunk +0 lines, -203 lines 0 comments Download
A content/public/browser/android/interface_provider_android.h View 1 2 3 4 1 chunk +43 lines, -0 lines 0 comments Download
A content/public/browser/android/interface_registry_android.h View 1 2 3 4 1 chunk +49 lines, -0 lines 0 comments Download
D content/public/browser/android/service_registry_android.h View 1 chunk +0 lines, -55 lines 0 comments Download
M content/shell/android/java/src/org/chromium/content_shell/ShellMojoTestUtils.java View 1 2 3 chunks +13 lines, -12 lines 0 comments Download
M content/shell/browser/shell_mojo_test_utils_android.cc View 1 2 3 chunks +29 lines, -37 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (14 generated)
Ben Goodger (Google)
4 years, 4 months ago (2016-07-28 22:48:20 UTC) #9
no sievers
lgtm https://codereview.chromium.org/2191033002/diff/60001/content/public/browser/android/interface_provider_android.h File content/public/browser/android/interface_provider_android.h (right): https://codereview.chromium.org/2191033002/diff/60001/content/public/browser/android/interface_provider_android.h#newcode26 content/public/browser/android/interface_provider_android.h:26: // The |registry| parameter must outlive |InterfaceProviderAndroid|. s/registry/remote_interfaces ...
4 years, 4 months ago (2016-07-29 18:02:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191033002/80001
4 years, 4 months ago (2016-07-29 18:13:11 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-07-29 19:09:17 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 19:10:39 UTC) #19
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/a2bfa904bfbfd746e4e61a7be05ca89c8b2b90f2
Cr-Commit-Position: refs/heads/master@{#408707}

Powered by Google App Engine
This is Rietveld 408576698