Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2191023002: [esnext] ship Object.getOwnPropertyDescriptors (Closed)

Created:
4 years, 4 months ago by caitp
Modified:
4 years, 4 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[esnext] ship Object.getOwnPropertyDescriptors Flip the --harmony_object_own_property_descriptors flag to enabled by default. Intent-to-Ship at https://groups.google.com/forum/#!topic/v8-users/xhTKRuY0_V8 BUG=v8:4725 R=adamk@chromium.org, littledan@chromium.org Committed: https://crrev.com/1326de9d9146850a2fbde2bcfedb657750634c22 Cr-Commit-Position: refs/heads/master@{#38181}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/flag-definitions.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
caitp
Flag flipping CL
4 years, 4 months ago (2016-07-28 20:18:23 UTC) #1
adamk
lgtm
4 years, 4 months ago (2016-07-28 20:52:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191023002/1
4 years, 4 months ago (2016-07-29 14:22:25 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 14:45:31 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 14:46:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1326de9d9146850a2fbde2bcfedb657750634c22
Cr-Commit-Position: refs/heads/master@{#38181}

Powered by Google App Engine
This is Rietveld 408576698