Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2190983002: Splitting fpdfdoc/doc_* part III. (Closed)

Created:
4 years, 4 months ago by dsinclair
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com, npm
Base URL:
https://pdfium.googlesource.com/pdfium.git@fpdf_doc_IV
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Splitting fpdfdoc/doc_* part III. This CL cleans up the remaining doc_* files, splitting into .h and .pp files as needed. Committed: https://pdfium.googlesource.com/pdfium/+/27053d81ca80a2f9433abf3e9c393d2914c91ad8

Patch Set 1 #

Patch Set 2 : Rebase to master #

Total comments: 6

Patch Set 3 : Review fixes #

Patch Set 4 : Rebase to master #

Patch Set 5 : Fixup merge issues #

Patch Set 6 : Move struct definition up #

Patch Set 7 : move cb #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1350 lines, -4019 lines) Patch
M BUILD.gn View 1 2 3 2 chunks +8 lines, -5 lines 0 comments Download
A core/fpdfdoc/cpdf_apsettings.cpp View 1 chunk +119 lines, -0 lines 0 comments Download
A core/fpdfdoc/cpdf_defaultappearance.cpp View 1 2 3 4 1 chunk +222 lines, -0 lines 0 comments Download
A + core/fpdfdoc/cpdf_formcontrol.cpp View 1 2 9 chunks +20 lines, -129 lines 0 comments Download
A + core/fpdfdoc/cpdf_formfield.cpp View 15 chunks +94 lines, -84 lines 0 comments Download
A core/fpdfdoc/cpdf_iconfit.cpp View 1 chunk +48 lines, -0 lines 0 comments Download
A + core/fpdfdoc/cpdf_interform.cpp View 1 2 3 4 5 6 30 chunks +749 lines, -317 lines 0 comments Download
A core/fpdfdoc/cpdf_numbertree.h View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
A core/fpdfdoc/cpdf_numbertree.cpp View 1 chunk +52 lines, -0 lines 0 comments Download
M core/fpdfdoc/cpdf_pagelabel.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpvt_fontmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
D core/fpdfdoc/doc_form.cpp View 1 chunk +0 lines, -1203 lines 0 comments Download
D core/fpdfdoc/doc_formcontrol.cpp View 1 chunk +0 lines, -438 lines 0 comments Download
D core/fpdfdoc/doc_formfield.cpp View 1 chunk +0 lines, -987 lines 0 comments Download
D core/fpdfdoc/doc_utils.h View 1 chunk +0 lines, -79 lines 0 comments Download
D core/fpdfdoc/doc_utils.cpp View 1 2 3 4 1 chunk +0 lines, -770 lines 0 comments Download
M core/fpdfdoc/include/cpdf_formfield.h View 1 chunk +1 line, -0 lines 0 comments Download
M core/fpdfdoc/include/cpdf_interform.h View 1 chunk +4 lines, -0 lines 0 comments Download
M pdfium.gyp View 1 2 3 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 27 (17 generated)
dsinclair
PTAL.
4 years, 4 months ago (2016-07-28 18:30:52 UTC) #2
Lei Zhang
Got red gyp and win bots. https://codereview.chromium.org/2190983002/diff/20001/core/fpdfdoc/cpdf_defaultappearance.cpp File core/fpdfdoc/cpdf_defaultappearance.cpp (right): https://codereview.chromium.org/2190983002/diff/20001/core/fpdfdoc/cpdf_defaultappearance.cpp#newcode133 core/fpdfdoc/cpdf_defaultappearance.cpp:133: void CPDF_DefaultAppearance::GetColor(FX_ARGB& color, ...
4 years, 4 months ago (2016-07-28 22:15:06 UTC) #8
dsinclair
https://codereview.chromium.org/2190983002/diff/20001/core/fpdfdoc/cpdf_defaultappearance.cpp File core/fpdfdoc/cpdf_defaultappearance.cpp (right): https://codereview.chromium.org/2190983002/diff/20001/core/fpdfdoc/cpdf_defaultappearance.cpp#newcode133 core/fpdfdoc/cpdf_defaultappearance.cpp:133: void CPDF_DefaultAppearance::GetColor(FX_ARGB& color, On 2016/07/28 22:15:06, Lei Zhang wrote: ...
4 years, 4 months ago (2016-08-02 18:12:32 UTC) #9
Lei Zhang
lgtm
4 years, 4 months ago (2016-08-02 19:15:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190983002/60001
4 years, 4 months ago (2016-08-02 19:19:07 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux on master.tryserver.client.pdfium (JOB_FAILED, https://build.chromium.org/p/tryserver.client.pdfium/builders/linux/builds/1503)
4 years, 4 months ago (2016-08-02 19:28:58 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190983002/80001
4 years, 4 months ago (2016-08-02 19:54:53 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_no_v8 on master.tryserver.client.pdfium (JOB_FAILED, https://build.chromium.org/p/tryserver.client.pdfium/builders/win_no_v8/builds/1508) win_xfa_rel_gyp on master.tryserver.client.pdfium (JOB_FAILED, ...
4 years, 4 months ago (2016-08-02 20:01:06 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190983002/120001
4 years, 4 months ago (2016-08-02 22:28:22 UTC) #25
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 22:43:53 UTC) #27
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) as
https://pdfium.googlesource.com/pdfium/+/27053d81ca80a2f9433abf3e9c393d2914c9...

Powered by Google App Engine
This is Rietveld 408576698