Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: src/libplatform/tracing/trace-writer.h

Issue 2190973003: [Tracing] V8 Tracing Controller - Add args and copy support (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: More fixes Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/libplatform/tracing/trace-writer.h
diff --git a/src/libplatform/tracing/trace-writer.h b/src/libplatform/tracing/trace-writer.h
index d12ed4bffbc3277cfd89e65dca0110539b2a86c4..07bfd1f4d07adc7cc0558e3e816634b9c44223ac 100644
--- a/src/libplatform/tracing/trace-writer.h
+++ b/src/libplatform/tracing/trace-writer.h
@@ -13,12 +13,15 @@ namespace tracing {
class JSONTraceWriter : public TraceWriter {
public:
- explicit JSONTraceWriter(std::ostream& stream);
+ JSONTraceWriter(Isolate* isolate, std::ostream& stream);
~JSONTraceWriter();
void AppendTraceEvent(TraceObject* trace_event) override;
void Flush() override;
private:
+ void AppendTraceValue(uint8_t type, TraceObject::TraceValue value);
+
+ Isolate* isolate_;
std::ostream& stream_;
bool append_comma_ = false;
};

Powered by Google App Engine
This is Rietveld 408576698