Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/libplatform/tracing/trace-writer.h

Issue 2190973003: [Tracing] V8 Tracing Controller - Add args and copy support (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Use V8_INLINE static for non-class functions Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SRC_LIBPLATFORM_TRACING_TRACE_WRITER_H_ 5 #ifndef SRC_LIBPLATFORM_TRACING_TRACE_WRITER_H_
6 #define SRC_LIBPLATFORM_TRACING_TRACE_WRITER_H_ 6 #define SRC_LIBPLATFORM_TRACING_TRACE_WRITER_H_
7 7
8 #include "include/libplatform/v8-tracing.h" 8 #include "include/libplatform/v8-tracing.h"
9 9
10 namespace v8 { 10 namespace v8 {
11 namespace platform { 11 namespace platform {
12 namespace tracing { 12 namespace tracing {
13 13
14 class JSONTraceWriter : public TraceWriter { 14 class JSONTraceWriter : public TraceWriter {
15 public: 15 public:
16 explicit JSONTraceWriter(std::ostream& stream); 16 explicit JSONTraceWriter(std::ostream& stream);
17 ~JSONTraceWriter(); 17 ~JSONTraceWriter();
18 void AppendTraceEvent(TraceObject* trace_event) override; 18 void AppendTraceEvent(TraceObject* trace_event) override;
19 void Flush() override; 19 void Flush() override;
20 20
21 private: 21 private:
22 void AppendArgValue(uint8_t type, TraceObject::ArgValue value);
23
22 std::ostream& stream_; 24 std::ostream& stream_;
23 bool append_comma_ = false; 25 bool append_comma_ = false;
24 }; 26 };
25 27
26 } // namespace tracing 28 } // namespace tracing
27 } // namespace platform 29 } // namespace platform
28 } // namespace v8 30 } // namespace v8
29 31
30 #endif // SRC_LIBPLATFORM_TRACING_TRACE_WRITER_H_ 32 #endif // SRC_LIBPLATFORM_TRACING_TRACE_WRITER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698