X87: Reland of [interpreter] Add explicit OSR polling bytecode. (patchset #1 id:1 of https://codere…

X87: Reland of [interpreter] Add explicit OSR polling bytecode. (patchset #1 id:1 of https://codereview.chromium.org/2184553003/ ).

  port e1ad114ed2333a1b0792970a9a6f88d4127dfe70 (r38056)

  original commit message:
  Reason for revert:
  Fix has been landed.

  Original issue's description:
  > Revert of [interpreter] Add explicit OSR polling bytecode. (patchset #6 id:100001 of https://codereview.chromium.org/2172233002/ )
  >
  > Reason for revert:
  > Bunch of breakages. Maybe bad interaction with https://chromium.googlesource.com/v8/v8/+/e520e5da5550f0d1a975e87d6e66a2edecbb0c8e ?
  >
  > E.g.:
  > https://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/11607
  >
  > Original issue's description:
  > > [interpreter] Add explicit OSR polling bytecode.
  > >
  > > This adds an explicit {OsrPoll} bytecode into every loop header which
  > > triggers on-stack replacement when armed. Note that each such bytecode
  > > stores the static loop depths as an operand, and hence can be armed for
  > > specific loop depths.
  > >
  > > This also adds builtin code that triggers OSR compilation and switches
  > > execution over to optimized code in case compilation succeeds. In case
  > > compilation fails, the bytecode dispatch just continues unhindered.
  > >
  > > R=rmcilroy@chromium.org
  > > TEST=mjsunit/ignition/osr-from-bytecode
  > > BUG=v8:4764
> >
  > > Committed: https://crrev.com/a55beb68e0ededb3773affa294a71edc50621458
  > > Cr-Commit-Position: refs/heads/master@{#38043}
  >
  > TBR=rmcilroy@chromium.org,mstarzinger@chromium.org
  > # Skipping CQ checks because original CL landed less than 1 days ago.
  > NOPRESUBMIT=true
  > NOTREECHECKS=true
  > NOTRY=true
  > BUG=v8:4764
>
  > Committed: https://crrev.com/439aa2c6d708bfd95db725bd6f97c4c49bbc51fc
  > Cr-Commit-Position: refs/heads/master@{#38044}

BUG=

Committed: https://crrev.com/d80772270fd69187f60485e20c1af9a307dd9e13
Cr-Commit-Position: refs/heads/master@{#38122}

[zhengxing.li, 2016-07-28 07:58:01]

zhengxing.li@intel.com changed reviewers:
+ chunyang.dai@intel.com, mstarzinger@chromium.org, weiliang.lin@intel.com

[zhengxing.li, 2016-07-28 07:58:01]

PTAL, thanks!

[zhengxing.li, 2016-07-28 07:58:02]

PTAL, thanks!

[Michael Starzinger, 2016-07-28 07:59:33]

LGTM. Thanks!

[Weiliang, 2016-07-28 08:10:36]

On 2016/07/28 07:59:33, Michael Starzinger wrote:
> LGTM. Thanks!

lgtm

[zhengxing.li, 2016-07-28 08:53:35]

The CQ bit was checked by zhengxing.li@intel.com

[commit-bot: I haz the power, 2016-07-28 08:53:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 09:14:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-28 09:17:35]

Description was changed from

==========
X87: Reland of [interpreter] Add explicit OSR polling bytecode. (patchset #1
id:1 of https://codereview.chromium.org/2184553003/ ).

  port e1ad114ed2333a1b0792970a9a6f88d4127dfe70 (r38056)

  original commit message:
  Reason for revert:
  Fix has been landed.

  Original issue's description:
  > Revert of [interpreter] Add explicit OSR polling bytecode. (patchset #6
id:100001 of https://codereview.chromium.org/2172233002/ )
  >
  > Reason for revert:
  > Bunch of breakages. Maybe bad interaction with
https://chromium.googlesource.com/v8/v8/+/e520e5da5550f0d1a975e87d6e66a2edecb...
?
  >
  > E.g.:
  > https://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/11607
  >
  > Original issue's description:
  > > [interpreter] Add explicit OSR polling bytecode.
  > >
  > > This adds an explicit {OsrPoll} bytecode into every loop header which
  > > triggers on-stack replacement when armed. Note that each such bytecode
  > > stores the static loop depths as an operand, and hence can be armed for
  > > specific loop depths.
  > >
  > > This also adds builtin code that triggers OSR compilation and switches
  > > execution over to optimized code in case compilation succeeds. In case
  > > compilation fails, the bytecode dispatch just continues unhindered.
  > >
  > > R=rmcilroy@chromium.org
  > > TEST=mjsunit/ignition/osr-from-bytecode
  > > BUG=v8:4764
  > >
  > > Committed: https://crrev.com/a55beb68e0ededb3773affa294a71edc50621458
  > > Cr-Commit-Position: refs/heads/master@{#38043}
  >
  > TBR=rmcilroy@chromium.org,mstarzinger@chromium.org
  > # Skipping CQ checks because original CL landed less than 1 days ago.
  > NOPRESUBMIT=true
  > NOTREECHECKS=true
  > NOTRY=true
  > BUG=v8:4764
  >
  > Committed: https://crrev.com/439aa2c6d708bfd95db725bd6f97c4c49bbc51fc
  > Cr-Commit-Position: refs/heads/master@{#38044}

BUG=
==========

to

==========
X87: Reland of [interpreter] Add explicit OSR polling bytecode. (patchset #1
id:1 of https://codereview.chromium.org/2184553003/ ).

  port e1ad114ed2333a1b0792970a9a6f88d4127dfe70 (r38056)

  original commit message:
  Reason for revert:
  Fix has been landed.

  Original issue's description:
  > Revert of [interpreter] Add explicit OSR polling bytecode. (patchset #6
id:100001 of https://codereview.chromium.org/2172233002/ )
  >
  > Reason for revert:
  > Bunch of breakages. Maybe bad interaction with
https://chromium.googlesource.com/v8/v8/+/e520e5da5550f0d1a975e87d6e66a2edecb...
?
  >
  > E.g.:
  > https://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/11607
  >
  > Original issue's description:
  > > [interpreter] Add explicit OSR polling bytecode.
  > >
  > > This adds an explicit {OsrPoll} bytecode into every loop header which
  > > triggers on-stack replacement when armed. Note that each such bytecode
  > > stores the static loop depths as an operand, and hence can be armed for
  > > specific loop depths.
  > >
  > > This also adds builtin code that triggers OSR compilation and switches
  > > execution over to optimized code in case compilation succeeds. In case
  > > compilation fails, the bytecode dispatch just continues unhindered.
  > >
  > > R=rmcilroy@chromium.org
  > > TEST=mjsunit/ignition/osr-from-bytecode
  > > BUG=v8:4764
  > >
  > > Committed: https://crrev.com/a55beb68e0ededb3773affa294a71edc50621458
  > > Cr-Commit-Position: refs/heads/master@{#38043}
  >
  > TBR=rmcilroy@chromium.org,mstarzinger@chromium.org
  > # Skipping CQ checks because original CL landed less than 1 days ago.
  > NOPRESUBMIT=true
  > NOTREECHECKS=true
  > NOTRY=true
  > BUG=v8:4764
  >
  > Committed: https://crrev.com/439aa2c6d708bfd95db725bd6f97c4c49bbc51fc
  > Cr-Commit-Position: refs/heads/master@{#38044}

BUG=

Committed: https://crrev.com/d80772270fd69187f60485e20c1af9a307dd9e13
Cr-Commit-Position: refs/heads/master@{#38122}
==========

[commit-bot: I haz the power, 2016-07-28 09:17:36]

Patchset 1 (id:??) landed as
https://crrev.com/d80772270fd69187f60485e20c1af9a307dd9e13
Cr-Commit-Position: refs/heads/master@{#38122}