Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: src/pdf/SkPDFFormXObject.cpp

Issue 2190883003: SkPDF: PDFStream has-a not is-a PDFDict (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: 2016-07-28 (Thursday) 11:59:34 EDT Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/pdf/SkPDFFormXObject.cpp
diff --git a/src/pdf/SkPDFFormXObject.cpp b/src/pdf/SkPDFFormXObject.cpp
index 1ab391c3460a78f27bba186af11a2f3529e07382..5c0a576f99e4b7692963f6827991d448bc2bc57e 100644
--- a/src/pdf/SkPDFFormXObject.cpp
+++ b/src/pdf/SkPDFFormXObject.cpp
@@ -13,10 +13,10 @@ sk_sp<SkPDFObject> SkPDFMakeFormXObject(std::unique_ptr<SkStreamAsset> content,
sk_sp<SkPDFDict> resourceDict,
const char* colorSpace) {
auto form = sk_make_sp<SkPDFStream>(std::move(content));
- form->insertName("Type", "XObject");
- form->insertName("Subtype", "Form");
- form->insertObject("Resources", std::move(resourceDict));
- form->insertObject("BBox", std::move(mediaBox));
+ form->dict()->insertName("Type", "XObject");
+ form->dict()->insertName("Subtype", "Form");
+ form->dict()->insertObject("Resources", std::move(resourceDict));
+ form->dict()->insertObject("BBox", std::move(mediaBox));
// Right now FormXObject is only used for saveLayer, which implies
// isolated blending. Do this conditionally if that changes.
@@ -28,6 +28,6 @@ sk_sp<SkPDFObject> SkPDFMakeFormXObject(std::unique_ptr<SkStreamAsset> content,
group->insertName("CS", colorSpace);
}
group->insertBool("I", true); // Isolated.
- form->insertObject("Group", std::move(group));
+ form->dict()->insertObject("Group", std::move(group));
return form;
}
« no previous file with comments | « src/pdf/SkPDFFormXObject.h ('k') | src/pdf/SkPDFGraphicState.h » ('j') | src/pdf/SkPDFTypes.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698