Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: src/pdf/SkPDFFormXObject.cpp

Issue 2190883003: SkPDF: PDFStream has-a not is-a PDFDict (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: 2016-07-29 (Friday) 12:30:20 EDT Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/pdf/SkPDFFormXObject.h ('k') | src/pdf/SkPDFGraphicState.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/pdf/SkPDFFormXObject.cpp
diff --git a/src/pdf/SkPDFFormXObject.cpp b/src/pdf/SkPDFFormXObject.cpp
index e6445f517ae56f0f2fff4b75b4f684640a69f3bd..d0c7fe76c51d04937c23d7599f9c84df84f34053 100644
--- a/src/pdf/SkPDFFormXObject.cpp
+++ b/src/pdf/SkPDFFormXObject.cpp
@@ -15,14 +15,14 @@ sk_sp<SkPDFObject> SkPDFMakeFormXObject(std::unique_ptr<SkStreamAsset> content,
const SkMatrix& inverseTransform,
const char* colorSpace) {
auto form = sk_make_sp<SkPDFStream>(std::move(content));
- form->insertName("Type", "XObject");
- form->insertName("Subtype", "Form");
+ form->dict()->insertName("Type", "XObject");
+ form->dict()->insertName("Subtype", "Form");
if (!inverseTransform.isIdentity()) {
- form->insertObject("Matrix",
- SkPDFUtils::MatrixToArray(inverseTransform));
+ sk_sp<SkPDFObject> mat(SkPDFUtils::MatrixToArray(inverseTransform));
+ form->dict()->insertObject("Matrix", std::move(mat));
}
- form->insertObject("Resources", std::move(resourceDict));
- form->insertObject("BBox", std::move(mediaBox));
+ form->dict()->insertObject("Resources", std::move(resourceDict));
+ form->dict()->insertObject("BBox", std::move(mediaBox));
// Right now FormXObject is only used for saveLayer, which implies
// isolated blending. Do this conditionally if that changes.
@@ -34,6 +34,6 @@ sk_sp<SkPDFObject> SkPDFMakeFormXObject(std::unique_ptr<SkStreamAsset> content,
group->insertName("CS", colorSpace);
}
group->insertBool("I", true); // Isolated.
- form->insertObject("Group", std::move(group));
+ form->dict()->insertObject("Group", std::move(group));
return form;
}
« no previous file with comments | « src/pdf/SkPDFFormXObject.h ('k') | src/pdf/SkPDFGraphicState.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698